From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdbsP-000493-7w for qemu-devel@nongnu.org; Thu, 02 Apr 2015 05:57:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdbsO-0001Di-88 for qemu-devel@nongnu.org; Thu, 02 Apr 2015 05:57:29 -0400 Date: Thu, 2 Apr 2015 10:57:20 +0100 From: Stefan Hajnoczi Message-ID: <20150402095720.GA25244@stefanha-thinkpad.redhat.com> References: <1426879023-18151-1-git-send-email-jsnow@redhat.com> <1426879023-18151-5-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <1426879023-18151-5-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v4 04/20] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, mreitz@redhat.com --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 20, 2015 at 03:16:47PM -0400, John Snow wrote: > The new command pair is added to manage a user created dirty bitmap. The > dirty bitmap's name is mandatory and must be unique for the same device, > but different devices can have bitmaps with the same names. >=20 > The granularity is an optional field. If it is not specified, we will > choose a default granularity based on the cluster size if available, > clamped to between 4K and 64K to mirror how the 'mirror' code was > already choosing granularity. If we do not have cluster size info > available, we choose 64K. This code has been factored out into a helper > shared with block/mirror. >=20 > This patch also introduces the 'block_dirty_bitmap_lookup' helper, > which takes a device name and a dirty bitmap name and validates the > lookup, returning NULL and setting errp if there is a problem with > either field. This helper will be re-used in future patches in this > series. >=20 > The types added to block-core.json will be re-used in future patches > in this series, see: > 'qapi: Add transaction support to block-dirty-bitmap-{add, enable, disabl= e}' >=20 > Signed-off-by: John Snow > --- > block.c | 20 +++++++++ > block/mirror.c | 10 +---- > blockdev.c | 117 ++++++++++++++++++++++++++++++++++++++++++++= ++++++ > include/block/block.h | 1 + > qapi/block-core.json | 55 ++++++++++++++++++++++++ > qmp-commands.hx | 56 ++++++++++++++++++++++++ > 6 files changed, 250 insertions(+), 9 deletions(-) Reviewed-by: Stefan Hajnoczi --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVHRKAAAoJEJykq7OBq3PIbdwH/j+PBqWFe5YNGai9sCt9y6jr Ti2meQJBE/FY4isudTd+3Yy4BCTzSIQdFboGDAq3fixFUVpZrzKibYnDct6Jbmyq u0ab8z6BFDY20X+NecqWGXwT51jSSK5ews1hxS2GclGtGYW8HP9ueqKIkPczITG1 PiYQ7D8KNpEv+bzhaSkb9akLGV8Oo5vwETfcIhoQITW/y5oW3aX5NqeuVy9a2nUT sBZwKyAbT0NDxpb0dyx8swPD09YNoL34cP1Og0Xa28Wabuv/G+urrtw7J7Ggju45 kxo2FBnVeHwonu8oH7xJ/HIKqvGf0xgdRlQeazJERrZ6RTK+gSGSvAiVVXXfIOM= =mokr -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--