From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdfPZ-0001y1-Ik for qemu-devel@nongnu.org; Thu, 02 Apr 2015 09:43:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdfPY-0005Fl-Nk for qemu-devel@nongnu.org; Thu, 02 Apr 2015 09:43:57 -0400 Date: Thu, 2 Apr 2015 14:43:15 +0100 From: Stefan Hajnoczi Message-ID: <20150402134315.GK25244@stefanha-thinkpad.redhat.com> References: <1426879023-18151-1-git-send-email-jsnow@redhat.com> <1426879023-18151-17-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aziWXe2aaRGlkyg3" Content-Disposition: inline In-Reply-To: <1426879023-18151-17-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v4 16/20] hbitmap: truncate tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, mreitz@redhat.com --aziWXe2aaRGlkyg3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 20, 2015 at 03:16:59PM -0400, John Snow wrote: > The general approach is to set bits close to the boundaries of > where we are truncating and ensure that everything appears to > have gone OK. >=20 > We test growing and shrinking by different amounts: > - Less than the granularity > - Less than the granularity, but across a boundary > - Less than sizeof(unsigned long) > - Less than sizeof(unsigned long), but across a ulong boundary > - More than sizeof(unsigned long) >=20 > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > tests/test-hbitmap.c | 255 +++++++++++++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 255 insertions(+) Reviewed-by: Stefan Hajnoczi --aziWXe2aaRGlkyg3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVHUdzAAoJEJykq7OBq3PIBDcIAJz+7g95ZgXl9KHgKCQ82HyA lE62J73Crjlq/vnkFqMm10a5qRLFat7smqBIzM+y2wLOedvrCSuYRQtGDmx9+/5B FjfvBQM6pOhDTOYNm3gqgpHd3D4ai2eXLmZA+MpS4XDKEhs2UbWPKDAcpSfZTtgA ZJNdz5DqsoKABFSHMZZLmJJ54zrxVIH7a6AyHY9IRPTEz6axyxRTlSIlshg7YYBL DitgLQvjdXlySml574lFOJ5ON6UxeYLbxCg7HLZkm4y9EDVh0ZBo4gNEcQi0wYma +cz21ML2VVMq7aBGce1xoFFLCv2GGqJwTWXYaXWFnBjlPPG/rBiXwwW0KKeUkCA= =Ih+u -----END PGP SIGNATURE----- --aziWXe2aaRGlkyg3--