From: "Emilio G. Cota" <cota@braap.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc's bitmap
Date: Thu, 2 Apr 2015 20:08:10 -0400 [thread overview]
Message-ID: <20150403000810.GA21077@flamenco> (raw)
In-Reply-To: <1426919142-20770-1-git-send-email-cota@braap.org>
On Sat, Mar 21, 2015 at 02:25:42 -0400, Emilio G. Cota wrote:
> Note that this test
> if (b & ((1 << len) - 1))
> can be simplified to
> if (b & 1)
> , since we know that iff the first bit of a tb is set,
> all other bits from that tb are set too.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> translate-all.c | 39 +++++----------------------------------
> 1 file changed, 5 insertions(+), 34 deletions(-)
*ping*
http://patchwork.ozlabs.org/patch/452907/
Any takers? get_maintainer.pl doesn't suggest anybody to send this to.
This gets rid of an unnecessary (and hairy) function: bitmap_set().
I even took the time to double-check with a test program that
this function is indeed equivalent to bitmap_set().
Thanks,
Emilio
next prev parent reply other threads:[~2015-04-03 0:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 6:25 [Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc's bitmap Emilio G. Cota
2015-04-03 0:08 ` Emilio G. Cota [this message]
2015-04-03 14:18 ` Paolo Bonzini
2015-04-22 13:13 ` Paolo Bonzini
2015-04-22 16:47 ` Emilio G. Cota
2015-04-22 16:53 ` [Qemu-devel] [PATCH v2] " Emilio G. Cota
2015-04-22 20:30 ` Paolo Bonzini
2015-04-22 21:47 ` Emilio G. Cota
2015-04-22 21:50 ` [Qemu-devel] [PATCH v3] " Emilio G. Cota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403000810.GA21077@flamenco \
--to=cota@braap.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).