From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48470)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1Ydp9V-0002x1-Uc
	for qemu-devel@nongnu.org; Thu, 02 Apr 2015 20:08:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1Ydp9R-0000Bd-6T
	for qemu-devel@nongnu.org; Thu, 02 Apr 2015 20:08:01 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:49849)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1Ydp9R-0000BZ-2m
	for qemu-devel@nongnu.org; Thu, 02 Apr 2015 20:07:57 -0400
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
	by mailout.nyi.internal (Postfix) with ESMTP id 80D8F20A4E
	for <qemu-devel@nongnu.org>; Thu,  2 Apr 2015 20:07:53 -0400 (EDT)
Received: from localhost (unknown [128.59.20.216])
	by mail.messagingengine.com (Postfix) with ESMTPA id ADC4A6800A7
	for <qemu-devel@nongnu.org>; Thu,  2 Apr 2015 20:07:56 -0400 (EDT)
Date: Thu, 2 Apr 2015 20:08:10 -0400
From: "Emilio G. Cota" <cota@braap.org>
Message-ID: <20150403000810.GA21077@flamenco>
References: <1426919142-20770-1-git-send-email-cota@braap.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426919142-20770-1-git-send-email-cota@braap.org>
Subject: Re: [Qemu-devel] [PATCH] translate-all: use bitmap helpers for
	PageDesc's bitmap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sat, Mar 21, 2015 at 02:25:42 -0400, Emilio G. Cota wrote:
> Note that this test
> 	if (b & ((1 << len) - 1))
> can be simplified to
> 	if (b & 1)
> , since we know that iff the first bit of a tb is set,
> all other bits from that tb are set too.
> 
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  translate-all.c | 39 +++++----------------------------------
>  1 file changed, 5 insertions(+), 34 deletions(-)

*ping*
  http://patchwork.ozlabs.org/patch/452907/

Any takers? get_maintainer.pl doesn't suggest anybody to send this to.

This gets rid of an unnecessary (and hairy) function: bitmap_set().
I even took the time to double-check with a test program that
this function is indeed equivalent to bitmap_set().

Thanks,

		Emilio