From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yffki-0000Wn-Fw for qemu-devel@nongnu.org; Tue, 07 Apr 2015 22:30:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yffke-0003lW-GU for qemu-devel@nongnu.org; Tue, 07 Apr 2015 22:30:04 -0400 Date: Wed, 8 Apr 2015 11:55:55 +1000 From: David Gibson Message-ID: <20150408015555.GA28909@voom.redhat.com> References: <1427779727-13353-1-git-send-email-aik@ozlabs.ru> <1427779727-13353-3-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: <1427779727-13353-3-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH qemu v5 02/12] vmstate: Define VARRAY with VMS_ALLOC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Alex Williamson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 31, 2015 at 04:28:37PM +1100, Alexey Kardashevskiy wrote: > This allows dynamic allocation for migrating arrays. This commit message really needs more information for the benefit of people who haven't been buried in the savevm code recently. What existing VMSTATE macros does it extend? How do its semantics differ from them? What is this useful for that the existing macros are not? > Signed-off-by: Alexey Kardashevskiy > --- > include/migration/vmstate.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > index bc7616a..73b9d67 100644 > --- a/include/migration/vmstate.h > +++ b/include/migration/vmstate.h > @@ -299,6 +299,16 @@ extern const VMStateInfo vmstate_info_bitmap; > .offset =3D vmstate_offset_pointer(_state, _field, _type), \ > } > =20 > +#define VMSTATE_VARRAY_UINT32_ALLOC(_field, _state, _field_num, _version= , _info, _type) {\ > + .name =3D (stringify(_field)), \ > + .version_id =3D (_version), \ > + .num_offset =3D vmstate_offset_value(_state, _field_num, uint32_t),\ > + .info =3D &(_info), \ > + .size =3D sizeof(_type), \ > + .flags =3D VMS_VARRAY_UINT32|VMS_POINTER|VMS_ALLOC, \ > + .offset =3D vmstate_offset_pointer(_state, _field, _type), \ > +} > + > #define VMSTATE_VARRAY_UINT16_UNSAFE(_field, _state, _field_num, _versio= n, _info, _type) {\ > .name =3D (stringify(_field)), \ > .version_id =3D (_version), \ --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVJIqrAAoJEGw4ysog2bOS0M0P/0jNdXLs251tFiQlmwGwJNxa KI7GtltLbSMRtyPOrFqQqt3zszV7o308N4uBjOCFgOlKAffAayI7GzIG0IREZbZp Pm8cHOlmcKZPqqTGDc3eovTyGV1KkvKLfrQQFEb2rAsBhZk7GABN9tMGApINaVUu RWgcO75zmjGm846v+YwIrpBdbtN3DM3yhI7WiNiGNpijadXso9dEHkbGw2mGKzTi M4DI0bFKVc5BKpipfdKrVfrgSN6wsqDWWvzS/UODBdTB+IIXopXegfw4GJwr+l/F q8ZRY1zFL3bBdoQfnYfUqirCxKPcVpywO8+GgLkFKbgxPDtQzr7jvhDHHsFnwyUN M0/4N07hevpPXlVOog5dCoALWkmg3KgYKyf4xsT7dg0yXtUONXncyFdNi1NWCj6o 7YPzhlbpASAGT2X3wNSSxGik82l79dOJBohQe3BakvDce5ZhCWBcZ3K6GvVbxCBb /XXrgRllpv4lJ8sWNtkKl+C5TVrd4dgwJeb0v8qJLm/+CbTJwdP3u9omN4MIo257 bXv9tU4iQo5v3TqwnjVmer/zBdVycMsk1UsgLJxmgeha/SSPcLotRSCPribwq4xM GvYBJPRN+vLHIBdHvfBI2700LQzFqVihnFOKx3bSQv8gOtQxqncn/CciRvL/oMbF CMOKaanFfdYwVZn5mTfl =wxyH -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--