From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yffkf-0000VX-R9 for qemu-devel@nongnu.org; Tue, 07 Apr 2015 22:30:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yffke-0003lb-HN for qemu-devel@nongnu.org; Tue, 07 Apr 2015 22:30:01 -0400 Date: Wed, 8 Apr 2015 12:05:10 +1000 From: David Gibson Message-ID: <20150408020510.GC28909@voom.redhat.com> References: <1427779727-13353-1-git-send-email-aik@ozlabs.ru> <1427779727-13353-6-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PuGuTyElPB9bOcsM" Content-Disposition: inline In-Reply-To: <1427779727-13353-6-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH qemu v5 05/12] vfio: spapr: Move SPAPR-related code to a separate file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Alex Williamson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf --PuGuTyElPB9bOcsM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 31, 2015 at 04:28:40PM +1100, Alexey Kardashevskiy wrote: > This moves SPAPR bits to a separate file to avoid pollution of x86 code. >=20 > This is a mechanical patch. >=20 > Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson Splitting out the iommu mode specific code seems sensible to me. A bunch of the functions that have moved look as if they're not inherently spapr specific - it's just that spapr is the only user so far. But I guess they can be moved back to common.c when and if another user comes along. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --PuGuTyElPB9bOcsM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVJIzWAAoJEGw4ysog2bOSYrwQAMZ8mxQG/eZ+XsByN7W0aNKO 4ViwKnUkXWiGQe5xKZ4Nf5b9+WFBjRW7BDwTjMMjrv2WJMPtIQCRjynHGMOKFNP4 IRzLfFHkF8fXIooxVr0Uz2VHXOsZ9ZbfP5GfDMa/qcgrV4FDNQlnkQE2VyrpFf2J 2uH+YCDP2r4S3V21XfYzs2cvvKExBfz7+m5DqzSu7QWuZ3d5YzJXqLeLXZTAFCqJ z2x9bNcPq1FJEGbojYj2jSsrA88yx2PYePH1WDJxjF0x926ckwKIKQOObCBcglk7 5eLziRCALH9CPtQibyVKwGchahdc63FBFyR9NjlJf7mSnlnDbIUAe203gs8kf+Zu N8g3L8hWIBwkosbYzhWd2+/3ydLFmweQ5wbduQ6Pj/t5G2qkxKt1G3EKgmzvSCqb kJHpGcikwlXKZ57zoMcLhylY+BQupn07DprLbVQA2RsaLV5utBtgSEXc6gPAfAiV QKeAcLdiGjuSC1GPbWFEIx9vJw3gi6gt9zKZ9avfbAnM4SMAkdUWcUlFMtJwOHW6 76Ej5FSvBmd3OPlmHYcyPsWIPmb2T1lwUaK1YNm0uxT7UpIK1e7P3uvWxVrk4ebp 9vjLt7WlH98A41Qgkb3L4kVGdBAJ6BtP1E4Uh8HaT6KnoOMVbB4fvsT5A/1Wyh/X UEb/TgopmYGmlxELyzdw =Fsj+ -----END PGP SIGNATURE----- --PuGuTyElPB9bOcsM--