Re: [Qemu-devel] [PATCH for-2.3 v2] qcow2: Fix header update with overridden backing file

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

On Tue, Apr 07, 2015 at 03:03:16PM +0200, Kevin Wolf wrote:
> In recent qemu versions, it is possible to override the backing file
> name and format that is stored in the image file with values given at
> runtime. In such cases, the temporary override could end up in the
> image header if the qcow2 header was updated, while obviously correct
> behaviour would be to leave the on-disk backing file path/format
> unchanged.
> 
> Fix this and add a test case for it.
> 
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> v2:
> - Now freeing instead of leaking the new strings in qcow2_close()
> 
>  block/qcow2.c              | 29 ++++++++++----
>  block/qcow2.h              |  6 +++
>  tests/qemu-iotests/130     | 95 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/130.out | 43 +++++++++++++++++++++
>  tests/qemu-iotests/group   |  1 +
>  5 files changed, 167 insertions(+), 7 deletions(-)
>  create mode 100755 tests/qemu-iotests/130
>  create mode 100644 tests/qemu-iotests/130.out

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]