qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Otubo <eduardo.otubo@profitbricks.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Marcus Meissner <meissner@suse.de>,
	Riku Voipio <riku.voipio@iki.fi>,
	qemu-devel <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>, Paul Moore <pmoore@redhat.com>,
	qemu-ppc <qemu-ppc@nongnu.org>,
	Karl-Philipp Richter <krichter722@aol.de>
Subject: Re: [Qemu-devel] seccomp breakage on arm
Date: Thu, 9 Apr 2015 10:21:52 +0200	[thread overview]
Message-ID: <20150409082152.GA18873@vader> (raw)
In-Reply-To: <5525EB8B.5030501@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]

On Thu, Apr 09, 2015 at 05=01=31AM +0200, Andreas Färber wrote:
> Hello,
> 
> I am seeing the following build failure on openSUSE Tumbleweed armv7l
> with --enable-seccomp in v2.3.0-rc2:
> 
> [  551s] In file included from qemu-seccomp.c:16:0:
> [  551s] /usr/include/libseccomp/seccomp.h:177:23: error: '__NR_mmap'
> undeclared here (not in a function)
> [  551s]  #define SCMP_SYS(x)  (__NR_##x)
> [  551s]                        ^
> [  551s] qemu-seccomp.c:36:7: note: in expansion of macro 'SCMP_SYS'
> [  551s]      { SCMP_SYS(mmap), 247 },
> [  551s]        ^
> [  551s] /usr/include/libseccomp/seccomp.h:177:23: error:
> '__NR_getrlimit' undeclared here (not in a function)
> [  551s]  #define SCMP_SYS(x)  (__NR_##x)
> [  551s]                        ^
> [  551s] qemu-seccomp.c:57:7: note: in expansion of macro 'SCMP_SYS'
> [  551s]      { SCMP_SYS(getrlimit), 245 },
> [  551s]        ^
> [  551s] /home/abuild/rpmbuild/BUILD/qemu-2.3.0-rc2/rules.mak:57: recipe
> for target 'qemu-seccomp.o' failed
> [  551s] make: *** [qemu-seccomp.o] Error 1
> 
> Is this a problem with libseccomp 2.2.0 / master and needs to be fixed
> in the library? Or do we need to #ifdef some syscalls in qemu-seccomp.c?

This should be already fixed in the library as mentioned by the
maintainer in this[0] thread. Adding Paul Moore in CC. There's also a
bug entry on launchpad[1] for that. I provided the patch (before the
pull reuqest) requesting for some review and testing but never heard
back again. Also CC'ing Karl-Philipp Richter (bug owner) for some
opinions on that as well.

Regards,

[0] http://sourceforge.net/p/libseccomp/mailman/message/32955831/
[1] https://bugs.launchpad.net/qemu/+bug/1363641

-- 
Eduardo Otubo
ProfitBricks GmbH

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-04-09  8:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09  3:01 [Qemu-devel] seccomp breakage on arm Andreas Färber
2015-04-09  8:21 ` Eduardo Otubo [this message]
2015-04-09  9:10   ` Paul Moore
2015-04-09 12:28     ` Andreas Färber
2015-04-09 21:27       ` Paul Moore
2015-04-09 22:32         ` Peter Maydell
2015-04-09 23:46           ` Paul Moore
2015-04-10 12:44             ` Peter Maydell
2015-04-10 15:16               ` Paul Moore
2015-04-10 15:38                 ` Peter Maydell
2015-04-10 15:40                 ` Andreas Färber
2015-04-10 22:56                   ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409082152.GA18873@vader \
    --to=eduardo.otubo@profitbricks.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=krichter722@aol.de \
    --cc=meissner@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=pmoore@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).