From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhcbT-0004Ia-ES for qemu-devel@nongnu.org; Mon, 13 Apr 2015 07:32:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhcbQ-0001CZ-9A for qemu-devel@nongnu.org; Mon, 13 Apr 2015 07:32:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhcbQ-0001CS-4I for qemu-devel@nongnu.org; Mon, 13 Apr 2015 07:32:32 -0400 Date: Mon, 13 Apr 2015 13:32:28 +0200 From: "Michael S. Tsirkin" Message-ID: <20150413133153-mutt-send-email-mst@redhat.com> References: <1428436304-24044-1-git-send-email-minyard@acm.org> <1428436304-24044-15-git-send-email-minyard@acm.org> <20150412180834-mutt-send-email-mst@redhat.com> <552B1C45.1080304@acm.org> <20150413082924-mutt-send-email-mst@redhat.com> <552B80CB.6040407@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <552B80CB.6040407@redhat.com> Subject: Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Corey Minyard , qemu-devel@nongnu.org, Corey Minyard On Mon, Apr 13, 2015 at 10:39:39AM +0200, Paolo Bonzini wrote: > > > On 13/04/2015 08:36, Michael S. Tsirkin wrote: > >> > So you are suggesting each device add it's own SSDT? I'm not sure how > >> > that helps debugging, it seems simpler to add it to a common one. > > For example, it's easier to write a unit test: encode something specific > > in one of the IDs, then look it up. > > Which is, btw, something that's missing in this patchset. > > A unit test for what? > > Paolo The ACPI code added. With an extra table it would be easy to test that it's there. -- MST