From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support
Date: Mon, 13 Apr 2015 13:49:42 +0200 [thread overview]
Message-ID: <20150413134908-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20150413133521.274fd658.cornelia.huck@de.ibm.com>
On Mon, Apr 13, 2015 at 01:35:21PM +0200, Cornelia Huck wrote:
> On Mon, 13 Apr 2015 13:26:31 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Mon, Apr 13, 2015 at 10:02:58AM +0200, Cornelia Huck wrote:
>
> > > Also, doesn't get_features need to be modified as well so that
> > > VERSION_1 is advertised?
> >
> > virtio_pci_device_plugged seems to set it ATM. I'll re-test to confirm.
>
> Indeed, pci sets it, but ccw does not. And virtio-net, for example,
> sets it explicitly as well. We need to unify this :)
I'm inclined to set it in transport and black-list in specific devices.
--
MST
next prev parent reply other threads:[~2015-04-13 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 15:00 [Qemu-devel] [PATCH 1/2] virtio_balloon: header update for virtio 1 Michael S. Tsirkin
2015-04-12 15:00 ` [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support Michael S. Tsirkin
2015-04-13 8:02 ` Cornelia Huck
2015-04-13 11:26 ` Michael S. Tsirkin
2015-04-13 11:35 ` Cornelia Huck
2015-04-13 11:49 ` Michael S. Tsirkin [this message]
2015-04-13 12:15 ` Cornelia Huck
2015-04-13 14:20 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413134908-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).