From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhcsA-0003NJ-WE for qemu-devel@nongnu.org; Mon, 13 Apr 2015 07:49:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yhcs6-00070I-0j for qemu-devel@nongnu.org; Mon, 13 Apr 2015 07:49:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37748) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yhcs5-0006zl-RT for qemu-devel@nongnu.org; Mon, 13 Apr 2015 07:49:45 -0400 Date: Mon, 13 Apr 2015 13:49:42 +0200 From: "Michael S. Tsirkin" Message-ID: <20150413134908-mutt-send-email-mst@redhat.com> References: <1428849904-28953-1-git-send-email-mst@redhat.com> <1428849904-28953-2-git-send-email-mst@redhat.com> <20150413100258.1f2c636f.cornelia.huck@de.ibm.com> <20150413132110-mutt-send-email-mst@redhat.com> <20150413133521.274fd658.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150413133521.274fd658.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Rusty Russell , qemu-devel@nongnu.org, Anthony Liguori , virtualization@lists.linux-foundation.org On Mon, Apr 13, 2015 at 01:35:21PM +0200, Cornelia Huck wrote: > On Mon, 13 Apr 2015 13:26:31 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Apr 13, 2015 at 10:02:58AM +0200, Cornelia Huck wrote: > > > > Also, doesn't get_features need to be modified as well so that > > > VERSION_1 is advertised? > > > > virtio_pci_device_plugged seems to set it ATM. I'll re-test to confirm. > > Indeed, pci sets it, but ccw does not. And virtio-net, for example, > sets it explicitly as well. We need to unify this :) I'm inclined to set it in transport and black-list in specific devices. -- MST