From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhuNQ-0008Lv-ID for qemu-devel@nongnu.org; Tue, 14 Apr 2015 02:31:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhuNN-0008Su-BR for qemu-devel@nongnu.org; Tue, 14 Apr 2015 02:31:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhuNN-0008Si-3f for qemu-devel@nongnu.org; Tue, 14 Apr 2015 02:31:13 -0400 Date: Tue, 14 Apr 2015 08:31:03 +0200 From: "Michael S. Tsirkin" Message-ID: <20150414063103.GA16729@redhat.com> References: <1428436304-24044-1-git-send-email-minyard@acm.org> <1428436304-24044-11-git-send-email-minyard@acm.org> <20150412160524.GA13212@redhat.com> <552B1B56.1000709@acm.org> <20150413085824-mutt-send-email-mst@redhat.com> <552BF029.4040609@acm.org> <552BF18E.2010602@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <552BF18E.2010602@redhat.com> Subject: Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Corey Minyard , qemu-devel@nongnu.org, minyard@acm.org On Mon, Apr 13, 2015 at 06:40:46PM +0200, Paolo Bonzini wrote: > > > On 13/04/2015 18:34, Corey Minyard wrote: > > > > I made this the same as the ACPI code, which you have to have as a > > > > callback if you are adding it to a common SSDT. > > > > > > Not really I think. > > > > The AML functions require that you have a tree to attach what you are > > adding. If you did your own SSDT, you wouldn't need a callback. You > > could add a binary blob that gets put into the SSDT, but I think that > > would require adding some AML functions. > > I very much prefer the callback idea. Long term it could be used by > more devices and possibly it could be turned into an AMLProvider QOM > interface. Then the ACPI builder could iterate on all QOM devices and > just ask which of them can provide some AML. Yes, that would make sense. Devices which have a static AML could provide a static AML property, with very little code, those that have dynamic AML - dynamic AML property with more code. But I don't see callbacks as a step in that direction - more like code that will have to be ripped out later. I was looking for ways to remove dependencies for this patchset, not add them. > Also, tables are rebuilt when the firmware loads them, and handing in a > blob makes it harder to achieve this on-the-fly modification, compared > to callbacks. > > Paolo Well that's not true for smbios, is it? -- MST