From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33126)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yhtkz-0000dE-BX
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 01:51:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yhtkv-0003f8-0f
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 01:51:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51739)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yhtku-0003f0-OE
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 01:51:28 -0400
Date: Tue, 14 Apr 2015 07:51:22 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150414075108-mutt-send-email-mst@redhat.com>
References: <1427830813-639306-1-git-send-email-stefanb@linux.vnet.ibm.com>
	<1427830813-639306-4-git-send-email-stefanb@linux.vnet.ibm.com>
	<20150413082458-mutt-send-email-mst@redhat.com>
	<552C7B8C.7040506@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <552C7B8C.7040506@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] TPM2 ACPI table support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, quan.xu@intel.com

On Mon, Apr 13, 2015 at 10:29:32PM -0400, Stefan Berger wrote:
> On 04/13/2015 02:27 AM, Michael S. Tsirkin wrote:
> >>@@ -1428,12 +1444,22 @@ void acpi_build(PcGuestInfo *guest_info, AcpiBuildTables *tables)
> >>          acpi_add_table(table_offsets, tables_blob);
> >>          build_hpet(tables_blob, tables->linker);
> >>      }
> >>-    if (misc.has_tpm) {
> >>+    if (misc.tpm_version != TPMVersion_Unspec) {
> >>          acpi_add_table(table_offsets, tables_blob);
> >>          build_tpm_tcpa(tables_blob, tables->linker, tables->tcpalog);
> >>          acpi_add_table(table_offsets, tables_blob);
> >>-        build_tpm_ssdt(tables_blob, tables->linker);
> >>+        switch (misc.tpm_version) {
> >>+        case TPMVersion1_2:
> >>+            build_tpm_ssdt(tables_blob, tables->linker);
> >>+            break;
> >>+        case TPMVersion2_0:
> >>+            build_tpm2(tables_blob, tables->linker);
> >>+            break;
> >>+        case TPMVersion_Unspec:
> >>+            /* not possible */
> >>+            break;
> >>+        }
> >>      }
> >>      if (guest_info->numa_nodes) {
> >>          acpi_add_table(table_offsets, tables_blob);
> >I think we should fix QEMU coding style violations in TPM code.
> >In particular, mixing of _ and camel case, enum and define values
> >not all upper case, local variables not all lower case.
> >This was less of an issue when the violations were contained
> >within hw/tpm/, but it's more of an issue now that this affects
> >other code.
> >
> 
> The above enums look like the only violation to me. Fixed.
> 
>     Stefan


there's also needIrq in existing code, let's fix that.