From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yhtpp-00027a-4O
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 01:56:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yhtpk-00054Z-QD
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 01:56:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60346)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yhtpk-00054Q-Lm
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 01:56:28 -0400
Date: Tue, 14 Apr 2015 07:56:21 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150414075457-mutt-send-email-mst@redhat.com>
References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com>
	<1428055432-12120-17-git-send-email-zhaoshenglong@huawei.com>
	<87sic4ja5a.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <87sic4ja5a.fsf@linaro.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 16/20] hw/acpi/aml-build: Add aml_else()
 term
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, imammedo@redhat.com, a.spyridakis@virtualopensystems.com, msalter@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, Shannon Zhao <zhaoshenglong@huawei.com>, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org

On Mon, Apr 13, 2015 at 04:55:13PM +0100, Alex Benn=E9e wrote:
>=20
> Shannon Zhao <zhaoshenglong@huawei.com> writes:
>=20
> > From: Shannon Zhao <shannon.zhao@linaro.org>
> >
> > Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>=20
> I was considering if the magic numbers should be defined somewhere but =
I
> guess that is the point of the stub functions.

I don't think so: wrappers make sure each is used
only once.  enums would just obfuscate code.
comments are better in that they match the language
used in the acpi spec, exactly.

> Reviewed-by: Alex Benn=E9e <alex.bennee@linaro.org>

>=20
> > ---
> >  hw/acpi/aml-build.c         | 7 +++++++
> >  include/hw/acpi/aml-build.h | 1 +
> >  2 files changed, 8 insertions(+)
> >
> > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> > index 4f936f7..9b8b422 100644
> > --- a/hw/acpi/aml-build.c
> > +++ b/hw/acpi/aml-build.c
> > @@ -626,6 +626,13 @@ Aml *aml_if(Aml *predicate)
> >      return var;
> >  }
> > =20
> > +/* ACPI 1.0: 16.2.3 Operators: DefElse */
> > +Aml *aml_else(void)
> > +{
> > +    Aml *var =3D aml_bundle(0xA1 /* ElseOp */, AML_PACKAGE);
> > +    return var;
> > +}
> > +
> >  /* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefMethod */
> >  Aml *aml_method(const char *name, int arg_count)
> >  {
> > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.=
h
> > index 6b407d5..3901515 100644
> > --- a/include/hw/acpi/aml-build.h
> > +++ b/include/hw/acpi/aml-build.h
> > @@ -206,6 +206,7 @@ Aml *aml_scope(const char *name_format, ...) GCC_=
FMT_ATTR(1, 2);
> >  Aml *aml_device(const char *name_format, ...) GCC_FMT_ATTR(1, 2);
> >  Aml *aml_method(const char *name, int arg_count);
> >  Aml *aml_if(Aml *predicate);
> > +Aml *aml_else(void);
> >  Aml *aml_package(uint8_t num_elements);
> >  Aml *aml_buffer(void);
> >  Aml *aml_resource_template(void);
>=20
> --=20
> Alex Benn=E9e