From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi12m-0001x6-KA for qemu-devel@nongnu.org; Tue, 14 Apr 2015 09:38:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yi12i-0008Ax-Ft for qemu-devel@nongnu.org; Tue, 14 Apr 2015 09:38:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi12i-0008Ac-8F for qemu-devel@nongnu.org; Tue, 14 Apr 2015 09:38:20 -0400 Date: Tue, 14 Apr 2015 15:38:08 +0200 From: Thomas Huth Message-ID: <20150414153808.4a069d93@thh440s> In-Reply-To: <1428523369-13700-1-git-send-email-peter.maydell@linaro.org> References: <1428523369-13700-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Michael Roth Am Wed, 8 Apr 2015 21:02:49 +0100 schrieb Peter Maydell : > The second argument of g_base64_decode() is a 'gsize *', not a > 'size_t *'. Some compilation environments (like building 32-bit PPC > binaries on a PPC64 system) will complain about the mismatch: >=20 > CC qga/commands-posix.o > qga/commands-posix.c: In function 'qmp_guest_set_user_password': > qga/commands-posix.c:1908:5: error: passing argument 2 of 'g_base64_decod= e' from incompatible pointer type [-Werror] > In file included from /usr/include/glib-2.0/glib.h:37:0, > from qga/commands-posix.c:14: > /usr/include/glib-2.0/glib/gbase64.h:49:9: note: expected =E2=80=98gsize = *=E2=80=99 but argument is of type =E2=80=98size_t *=E2=80=99 >=20 > (We previously fixed errors of this type in commit 3d1bba20.) >=20 > Signed-off-by: Peter Maydell > --- > qga/commands-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index ba8de62..9fde348 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -1901,7 +1901,7 @@ void qmp_guest_set_user_password(const char *userna= me, > int status; > int datafd[2] =3D { -1, -1 }; > char *rawpasswddata =3D NULL; > - size_t rawpasswdlen; > + gsize rawpasswdlen; > char *chpasswddata =3D NULL; > size_t chpasswdlen; > =20 I've just ran into this issue as well on my x86 laptop when playing around with "--extra-cflags=3D-m32"... so should this be fixed for the 2.3 release already? I didn't spot your patch on the master branch yet... Anyway, your patch looks like the right solution: Reviewed-by: Thomas Huth