From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi3g7-0006eD-1W for qemu-devel@nongnu.org; Tue, 14 Apr 2015 12:27:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yi3g3-0004G2-Oe for qemu-devel@nongnu.org; Tue, 14 Apr 2015 12:27:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi3g3-0004Ft-H3 for qemu-devel@nongnu.org; Tue, 14 Apr 2015 12:27:07 -0400 Date: Tue, 14 Apr 2015 18:27:04 +0200 From: Martin Kletzander Message-ID: <20150414162704.GM4131@wheatley> References: <1427994155-25043-1-git-send-email-marcandre.lureau@gmail.com> <1427994155-25043-4-git-send-email-marcandre.lureau@gmail.com> <20150414142507.GI4131@wheatley> <552D3B24.4020803@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n1iI6MeELQa9IOaF" Content-Disposition: inline In-Reply-To: <552D3B24.4020803@redhat.com> Subject: Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: libvir-list@redhat.com, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , "qemu-devel@nongnu.org" --n1iI6MeELQa9IOaF Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 14, 2015 at 10:07:00AM -0600, Eric Blake wrote: >[adding qemu] > >On 04/14/2015 09:58 AM, Marc-Andr=E9 Lureau wrote: >> Hi >> >> On Tue, Apr 14, 2015 at 4:25 PM, Martin Kletzander >> wrote: >> >>> Is this not exposed in any way in QEMU? Do we really need to use this >>> (what we're trying to avoid)? >>> >> >> That works with the following change: >> >> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c >> index 768cef1..1b20a7f 100644 >> --- a/src/qemu/qemu_capabilities.c >> +++ b/src/qemu/qemu_capabilities.c >> @@ -2510,6 +2510,7 @@ struct virQEMUCapsCommandLineProps { >> >> static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] =3D { >> { "machine", "mem-merge", QEMU_CAPS_MEM_MERGE }, >> + { "machine", "vmport", QEMU_CAPS_MACHINE_VMPORT_OPT }, > >Ouch. qemu commit 0a7cf21 fixes what would have been a regression in >2.3 at exposing "mem-merge" through query-command-line-options, but it >does NOT expose "vmport", which is a per-architecture option rather than >a generic -machine option. Which means that even though qemu 2.2 >(perhaps wrongly) advertised "vmport" for all machines (even when it was >not supported), 2.3 will not advertise it, and we are hoping for a >better solution in 2.4 for properly advertising vmport on an >as-appropriate basis. > >Yes, we WANT to use QMP probing,... > >> { "drive", "discard", QEMU_CAPS_DRIVE_DISCARD }, >> { "realtime", "mlock", QEMU_CAPS_MLOCK }, >> { "boot-opts", "strict", QEMU_CAPS_BOOT_STRICT }, >> @@ -3243,10 +3244,6 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps, >> if (qemuCaps->version >=3D 1003000) >> virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT); >> >> - /* vmport option is supported v2.2.0 onwards */ >> - if (qemuCaps->version >=3D 2002000) >> - virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_VMPORT_OPT); > >...and not version comparison, but we'll need something better in QMP >for 2.3 (which is rather late, since we missed 2.3-rc3) if you can't >come up with anything better for learning whether vmport is supported. > Ouch, I missed that. But that's something we need for more than just vmport attribute, but also all other machine-specific ones :( I still think this might go in, though. --n1iI6MeELQa9IOaF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVLT/YAAoJEAgfwp8kF4bdRvgP/iyPFujarBhQ6HcbCwaFHbFG 9Bml+k8Wj038ZFuWWpxyIeCVmTMso06fo/FBwc8hkZ73XUQftTs1+PUktWDUdlzU 9gAdVJc4ki9alxnw6yTTqMxaJlH2n4pjrWqlYI4oWKAIoVRI9S4wRhsYZfXO3teZ I8HmAF8d9FqujPdaf9vBnI0G/XPMu2g+Ibh9ZF59TppbdUq0g6d+dxWjmAZG+nlK rntEqJpL2M61KqwXLr7qNyRHNc6uHnyeDco5x2jaQ0ydWJyfb6mV0q5441y1OjxN 9tYpgp7/JByLlZfMX1yuCJ4Vh6SPOKV1oaDdrqjc3Cc2mY8NwAKe3I7uh86lbDJH 1Ae+CAeK1TVCY3V09b6Y9Kr4sVMIvJQsUFbTWQcM4dWT9L9sPZKFESuiUgQ9+c9i gsO5angsxKn3KyVbLeJZZtrrFlWpIRfJTB0qOUStZTJ4KWgJz3ofqgnaD1TSoCqD WOBITGxsEA+1xB/5hs/VIprfklE+oUtyHRB1qyulu0ZmAn7KvFyl63O0sSrl6kcb knlCIdFAMb+kEksTtQ926cubeATNXLhUkOf4xmgyplm/SVFApeaVWyGS7ZGmGeIk 5Sbvkpoehe89eWnoalaz+t6aMIGm5oRcP2fh7k1SFgA3EeX8VTdzOyvlVE0gqxs4 BlFCGSXBPtapLVD7Oukg =cJYf -----END PGP SIGNATURE----- --n1iI6MeELQa9IOaF--