From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiJkT-0005jb-Ra for qemu-devel@nongnu.org; Wed, 15 Apr 2015 05:36:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiJkP-0004qT-NM for qemu-devel@nongnu.org; Wed, 15 Apr 2015 05:36:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiJkP-0004qE-HQ for qemu-devel@nongnu.org; Wed, 15 Apr 2015 05:36:41 -0400 Date: Wed, 15 Apr 2015 11:36:38 +0200 From: "Michael S. Tsirkin" Message-ID: <20150415113545-mutt-send-email-mst@redhat.com> References: <552DE3D2.5040109@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <552DE3D2.5040109@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH] vhost: pass corrent log base to kernel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang Cc: Paolo Bonzini , qemu-devl On Wed, Apr 15, 2015 at 12:06:42PM +0800, Wen Congyang wrote: > Signed-off-by: Wen Congyang > --- > hw/virtio/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > index 5a12861..4e334ca 100644 > --- a/hw/virtio/vhost.c > +++ b/hw/virtio/vhost.c > @@ -1060,7 +1060,7 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev) > hdev->log_size = vhost_get_log_size(hdev); > hdev->log = hdev->log_size ? > g_malloc0(hdev->log_size * sizeof *hdev->log) : NULL; > - r = hdev->vhost_ops->vhost_call(hdev, VHOST_SET_LOG_BASE, hdev->log); > + r = hdev->vhost_ops->vhost_call(hdev, VHOST_SET_LOG_BASE, &hdev->log); > if (r < 0) { > r = -errno; > goto fail_log; Wow that's a serious bug. But your patch won't work correctly on 32 bit systems. I'll send a fixed patch. Thanks! > -- > 2.1.0