From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YioxI-0006sE-JS for qemu-devel@nongnu.org; Thu, 16 Apr 2015 14:56:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YioxC-0001nr-LN for qemu-devel@nongnu.org; Thu, 16 Apr 2015 14:56:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YioxC-0001nb-Dp for qemu-devel@nongnu.org; Thu, 16 Apr 2015 14:55:58 -0400 Date: Thu, 16 Apr 2015 20:55:04 +0200 From: "Michael S. Tsirkin" Message-ID: <20150416205335-mutt-send-email-mst@redhat.com> References: <1429137528-1069064-1-git-send-email-stefanb@linux.vnet.ibm.com> <20150416153506.3260becd@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150416153506.3260becd@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: safford@watson.ibm.com, qemu-devel@nongnu.org, quan.xu@intel.com, Stefan Berger On Thu, Apr 16, 2015 at 03:35:06PM +0200, Igor Mammedov wrote: > On Wed, 15 Apr 2015 18:38:43 -0400 > Stefan Berger wrote: > > > The following series of patches extends TPM support with an > > external TPM that offers a Linux CUSE (character device in userspace) > > interface. This TPM lets each VM access its own private vTPM. > > The CUSE TPM supports suspend/resume and migration. Much > > out-of-band functionality necessary to control the CUSE TPM is > > implemented using ioctl's. > > > > The series extends the TPM support so far that most functionality of > > TPM support on a physical platform is now available to each x86 VM, > > this includes the Physical Presence Interface support that has > > its counter-part in the SeaBIOS and is implemented using ACPI. > > > > http://www.seabios.org/pipermail/seabios/2015-March/008978.html > is it already merged? > > Is it possible to use MMIO region instead of allocating tpm_ppi_anchor > and tpm_ppi in BIOS memory? > That would simplify BIOS part a bit and significantly simplify ACPI code > as most of it is dealing with figuring out address of tpm_ppi. Which (if it works) I guess brings us back to the idea of using a pci device with a bar where we can stick tpm+vm id+whatever? > > > > > > Stefan Berger (5): > > Provide support for the CUSE TPM > > Support Physical Presence Interface Spec > > Introduce condition to notifiy waiters of completed command > > Introduce condition in TPM backend for notification > > Add support for VM suspend/resume for TPM TIS > > > > hmp.c | 6 + > > hw/i386/acpi-tpm-core.dsl | 277 +++++++++++++++++++++++++++++ > > hw/i386/acpi-tpm2.dsl | 27 +++ > > hw/i386/q35-acpi-dsdt.dsl | 1 + > > hw/i386/ssdt-tpm.dsl | 12 +- > > hw/tpm/tpm_int.h | 4 + > > hw/tpm/tpm_ioctl.h | 178 +++++++++++++++++++ > > hw/tpm/tpm_passthrough.c | 410 +++++++++++++++++++++++++++++++++++++++++-- > > hw/tpm/tpm_tis.c | 152 +++++++++++++++- > > hw/tpm/tpm_tis.h | 2 + > > hw/tpm/tpm_util.c | 206 ++++++++++++++++++++++ > > hw/tpm/tpm_util.h | 7 + > > include/sysemu/tpm_backend.h | 12 ++ > > qapi-schema.json | 17 +- > > qemu-options.hx | 21 ++- > > qmp-commands.hx | 2 +- > > tpm.c | 11 +- > > 17 files changed, 1316 insertions(+), 29 deletions(-) > > create mode 100644 hw/i386/acpi-tpm-core.dsl > > create mode 100644 hw/i386/acpi-tpm2.dsl > > create mode 100644 hw/tpm/tpm_ioctl.h > >