From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj86O-0000IP-VP for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:22:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj86M-00009B-9o for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:22:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj86M-00008y-1b for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:22:42 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3HFMfHk006146 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 17 Apr 2015 11:22:41 -0400 Date: Fri, 17 Apr 2015 16:22:37 +0100 From: "Daniel P. Berrange" Message-ID: <20150417152237.GI23619@redhat.com> References: <1429280557-8887-1-git-send-email-berrange@redhat.com> <1429280557-8887-7-git-send-email-berrange@redhat.com> <55311F3B.8060305@redhat.com> <55312044.90604@redhat.com> <20150417151140.GG23619@redhat.com> <55312483.50500@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <55312483.50500@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 RFC 06/34] qom: add a object_property_add_enum helper method Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Gerd Hoffmann On Fri, Apr 17, 2015 at 05:19:31PM +0200, Paolo Bonzini wrote: > > > On 17/04/2015 17:11, Daniel P. Berrange wrote: > > > On second thought (after seeing patch 7), please add a property type > > > argument here. We lose introspection of enum property types otherwise. > > > > Can you give me a pointer to where we lose introspection ? The hostmem > > code just registers its 'policy' property with a type name of 'str', > > That was already a bug. :( It should have been registered as > "HostMemPolicy". See for example: Ok, next time I'll probably send a patch which fixes that bug independantly and then does the conversion, in case we want the fix on stable too. > $ qemu-system-x86_64 -device ide-hd,help > ide-hd.bootindex=int32 > ide-hd.unit=uint32 > ide-hd.bios-chs-trans=BiosAtaTranslation (Logical CHS translation algorithm, auto/none/lba/large/rechs) > ... > > > which I've just changed to 'enum' in patch 7, so I didn't think I was > > regressing anything. Is there some QMP command which you think looses > > the info that I can verify. > > The qom-list command returns a list of property names and types. Thanks, will look at that. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|