From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46344)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yj7y5-0001sf-0O
	for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:14:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yj7y4-0005p3-5F
	for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:14:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32985)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yj7y3-0005ov-Um
	for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:14:08 -0400
Date: Fri, 17 Apr 2015 17:13:57 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150417171352-mutt-send-email-mst@redhat.com>
References: <1429282526-31484-1-git-send-email-mst@redhat.com>
	<CAFEAcA_Xp3=ksc+f=mBxdcfn7MdtWUUNiqmDuuiRrRi3SXmHcA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_Xp3=ksc+f=mBxdcfn7MdtWUUNiqmDuuiRrRi3SXmHcA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3] vhost: fix log base address
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Fri, Apr 17, 2015 at 04:04:38PM +0100, Peter Maydell wrote:
> On 17 April 2015 at 15:56, Michael S. Tsirkin <mst@redhat.com> wrote:
> > VHOST_SET_LOG_BASE got an incorrect address, causing
> > migration errors and potentially even memory corruption.
> >
> > Reported-by: Wen Congyang <wency@cn.fujitsu.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > Built only.
> > Will test and report next week.
> > Wen Congyang, can you pls confirm as well?
> >
> >  hw/virtio/vhost.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> > index 8dd2f59..e4cf9d7 100644
> > --- a/hw/virtio/vhost.c
> > +++ b/hw/virtio/vhost.c
> > @@ -1016,10 +1016,13 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
> >      }
> >
> >      if (hdev->log_enabled) {
> > +        uint64_t log_base;
> > +
> >          hdev->log_size = vhost_get_log_size(hdev);
> >          hdev->log = hdev->log_size ?
> >              g_malloc0(hdev->log_size * sizeof *hdev->log) : NULL;
> > -        r = hdev->vhost_ops->vhost_call(hdev, VHOST_SET_LOG_BASE, hdev->log);
> > +        log_base = (uint64_t)(unsigned long)hdev->log;
> 
> Paolo asked you to make this cast just be a single (uintptr_t).
> 
> thanks
> -- PMM

done.