From: Amit Shah <amit.shah@redhat.com>
To: Michael Chapman <mike@very.puzzling.org>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: avoid divide by zero in xbzrle cache miss rate
Date: Mon, 20 Apr 2015 12:40:21 +0530 [thread overview]
Message-ID: <20150420071021.GB16776@grmbl.mre> (raw)
In-Reply-To: <1429070355-19862-1-git-send-email-mike@very.puzzling.org>
On (Wed) 15 Apr 2015 [13:59:14], Michael Chapman wrote:
> This bug manifested itself as a VM that could not be resumed by libvirt
> following a migration:
>
> # virsh resume example
> error: Failed to resume domain example
> error: internal error: cannot parse json {"return":
> {"xbzrle-cache":
> {..., "cache-miss-rate": -nan, ...},
> ...
> }
> }: lexical error: malformed number, a digit is required after the minus sign.
>
> This patch also ensures xbzrle_cache_miss_prev and iterations_prev are
> cleared at the start of the migration.
>
> Signed-off-by: Michael Chapman <mike@very.puzzling.org>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Amit
next prev parent reply other threads:[~2015-04-20 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 3:59 [Qemu-devel] [PATCH] migration: avoid divide by zero in xbzrle cache miss rate Michael Chapman
2015-04-20 7:10 ` Amit Shah [this message]
2015-04-22 11:39 ` Juan Quintela
2015-05-06 15:35 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420071021.GB16776@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=mike@very.puzzling.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).