From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkSdj-0001cq-V8 for qemu-devel@nongnu.org; Tue, 21 Apr 2015 03:30:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkSdg-0008Em-NX for qemu-devel@nongnu.org; Tue, 21 Apr 2015 03:30:39 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:51235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkSdg-0008ES-Cn for qemu-devel@nongnu.org; Tue, 21 Apr 2015 03:30:36 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Apr 2015 08:30:33 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id EE8C3219005E for ; Tue, 21 Apr 2015 08:30:13 +0100 (BST) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t3L7UTrV5701934 for ; Tue, 21 Apr 2015 07:30:29 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t3L7USxD015728 for ; Tue, 21 Apr 2015 01:30:29 -0600 Date: Tue, 21 Apr 2015 09:30:25 +0200 From: Cornelia Huck Message-ID: <20150421093025.4a64d51e.cornelia.huck@de.ibm.com> In-Reply-To: <5535AB48.6010808@linaro.org> References: <1429518001-1040-1-git-send-email-shannon.zhao@linaro.org> <1429518001-1040-2-git-send-email-shannon.zhao@linaro.org> <20150420133203.2fd6caff.cornelia.huck@de.ibm.com> <5535AB48.6010808@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, zhaoshenglong@huawei.com, pbonzini@redhat.com, christoffer.dall@linaro.org On Tue, 21 Apr 2015 09:43:36 +0800 Shannon Zhao wrote: > On 2015/4/20 19:32, Cornelia Huck wrote: > > On Mon, 20 Apr 2015 16:20:00 +0800 > > shannon.zhao@linaro.org wrote: > > > >> From: Shannon Zhao > >> > >> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. > >> The transports just sync the host features from backend. > >> > >> Signed-off-by: Shannon Zhao > >> Signed-off-by: Shannon Zhao > >> --- > >> hw/net/virtio-net.c | 4 ++++ > >> hw/s390x/s390-virtio-bus.c | 1 - > >> hw/s390x/virtio-ccw.c | 1 - > >> hw/virtio/virtio-pci.c | 1 - > >> include/hw/virtio/virtio-net.h | 1 + > >> 5 files changed, 5 insertions(+), 3 deletions(-) > > > > I need the following change to make this work for virtio-ccw: > > > > > Maybe we can use following patch. This moves virtio_net_set_config_size to > virtio_net_device_realize function. As the features are moved to virtio-net, > so we should set the config_size in virtio-net too. And this can be useful to > virtio-mmio which now doesn't call virtio_net_set_config_size in > virtio-mmio's realize function. I think this makes sense. > > Cornelia, could you check if this works on s390? Thanks. Networking works again via virtio-ccw with this patch on top. I'll still try to figure out a better sequence for realizing/plugging virtio-ccw devices, but I think that is orthogonal to this patch.