From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkV7R-0006kD-AF for qemu-devel@nongnu.org; Tue, 21 Apr 2015 06:09:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkV7M-0001Tp-9O for qemu-devel@nongnu.org; Tue, 21 Apr 2015 06:09:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkV7L-0001Tj-TK for qemu-devel@nongnu.org; Tue, 21 Apr 2015 06:09:24 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3LA9NW0001079 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 21 Apr 2015 06:09:23 -0400 Date: Tue, 21 Apr 2015 12:09:20 +0200 From: "Michael S. Tsirkin" Message-ID: <20150421120641-mutt-send-email-mst@redhat.com> References: <1429604772-2257-1-git-send-email-ghammer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429604772-2257-1-git-send-email-ghammer@redhat.com> Subject: Re: [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer Cc: imammedo@redhat.com, qemu-devel@nongnu.org On Tue, Apr 21, 2015 at 11:26:12AM +0300, Gal Hammer wrote: > A predefined scope in the ACPI specs is precede with a backslash. > > Signed-off-by: Gal Hammer s/precede/preceded/ This is correct, but do we need this in 2.3? I'm split on this. Thoughts? If yes, commit log needs better explanation on what the effect on guests is. > --- > hw/i386/acpi-build.c | 2 +- > include/hw/acpi/aml-build.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 8d1a761..05c1d34 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -856,7 +856,7 @@ build_ssdt(GArray *table_data, GArray *linker, > aml_append(ssdt, scope); > } > > - sb_scope = aml_scope("_SB"); > + sb_scope = aml_scope("\\_SB"); > { > /* create PCI0.PRES device and its _CRS to reserve CPU hotplug MMIO */ > dev = aml_device("PCI0." stringify(CPU_HOTPLUG_RESOURCE_DEVICE)); > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 48afb72..cb80f2a 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -120,7 +120,7 @@ void free_aml_allocator(void); > * Joins Aml elements together and helps to construct AML tables > * Examle of usage: > * Aml *table = aml_def_block("SSDT", ...); > - * Aml *sb = aml_scope("\_SB"); > + * Aml *sb = aml_scope("\\_SB"); > * Aml *dev = aml_device("PCI0"); > * > * aml_append(dev, aml_name_decl("HID", aml_eisaid("PNP0A03"))); > -- > 2.1.0