From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38004)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YkXgl-0006hQ-7K
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 08:54:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YkXgg-0004Hy-95
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 08:54:07 -0400
Received: from mail.kernel.org ([198.145.29.136]:43790)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YkXgg-0004HW-4k
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 08:54:02 -0400
Date: Tue, 21 Apr 2015 14:53:54 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150421125354.GA7727@redhat.com>
References: <1429604772-2257-1-git-send-email-ghammer@redhat.com>
	<20150421120641-mutt-send-email-mst@redhat.com>
	<CAFEAcA98SUNLKOg0xqam03nLAs-CnOpx_6y7PAybKppRbKgKAA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA98SUNLKOg0xqam03nLAs-CnOpx_6y7PAybKppRbKgKAA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB
	scope.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Gal Hammer <ghammer@redhat.com>, Igor Mammedov <imammedo@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Tue, Apr 21, 2015 at 12:33:36PM +0100, Peter Maydell wrote:
> On 21 April 2015 at 11:09, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Apr 21, 2015 at 11:26:12AM +0300, Gal Hammer wrote:
> >> A predefined scope in the ACPI specs is precede with a backslash.
> >>
> >> Signed-off-by: Gal Hammer <ghammer@redhat.com>
> >
> > s/precede/preceded/
> >
> > This is correct, but do we need this in 2.3?
> > I'm split on this. Thoughts?
> > If yes, commit log needs better explanation on what
> > the effect on guests is.
> 
> Unless the effect is absolutely catastrophic you've missed
> the boat for 2.3, and should settle for 2.4 + cc:stable.
> 
> thanks
> -- PMM

I rechecked a bunch of guests and they all seem to behave identically
with and without the patch.
2.4 it is.

Thanks.

-- 
MST