qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kashyap Chamarthy <kchamart@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org,
	qemu-devel@nongnu.org, mreitz@redhat.com,
	vsementsov@parallels.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2.5 00/10] block: incremental backup transactions
Date: Tue, 21 Apr 2015 16:48:50 +0200	[thread overview]
Message-ID: <20150421144850.GH5761@tesla.redhat.com> (raw)
In-Reply-To: <20150421135311.GB11726@tesla.redhat.com>

On Tue, Apr 21, 2015 at 03:53:11PM +0200, Kashyap Chamarthy wrote:

[. . .]

> And, invoking `drive-backup` *without* pre-creating the target image
> (i.e. 'incremental.o.img'):
> 
>     { 'execute': 'drive-backup',
>       'arguments': {
>         'device': 'ide0-0-0',

Small typo (in this email, not in my test): s/ide0-0-0/drive-ide0-0-0

>         'bitmap': 'bitmap0',
>         'sync': 'dirty-bitmap',
>         'target': 'incremental.0.img',
>         'mode': 'existing',
>         'format': 'qcow2'
>       }
>     }
> 
> Results in:
> 
>     {"QMP": {"version": {"qemu": {"micro": 93, "minor": 2, "major": 2},
>     "package": ""}, "capabilities": []}} {"return": {}}
> 
> Instead of an "error". Is this a bug?
> 
> On a related note, Kevin Wolf said on IRC that he gets an error
> (without 'bitmap') when tested from QEMU master branch.

On a separate machine, I tested the above behavior with master
(f2a5810), but I don't see any error, without 'bitmap' and with 'mode'
as 'existing', i.e.:

  { 'execute': 'drive-backup', 'arguments':
        { 'device': 'drive-virtio-disk0', 'sync': 'full', 'target':
        '/var/lib/libvirt/images/incremental.0.img', 'mode': 'existing', 'format': 'qcow2' } }

still results in:

    {"return": {}}

Maybe I doing something wrong?

-- 
/kashyap

  reply	other threads:[~2015-04-21 14:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 19:19 [Qemu-devel] [PATCH v2 00/11] block: incremental backup transactions John Snow
2015-03-27 19:19 ` [Qemu-devel] [PATCH v2 01/11] qapi: Add transaction support to block-dirty-bitmap operations John Snow
2015-04-17 14:41   ` Max Reitz
2015-04-17 14:50   ` Eric Blake
2015-03-27 19:19 ` [Qemu-devel] [PATCH v2 02/11] iotests: add transactional incremental backup test John Snow
2015-04-17 14:42   ` Max Reitz
2015-03-27 19:19 ` [Qemu-devel] [PATCH v2 03/11] block: rename BlkTransactionState and BdrvActionOps John Snow
2015-04-17 14:51   ` Max Reitz
2015-03-27 19:19 ` [Qemu-devel] [PATCH v2 04/11] block: re-add BlkTransactionState John Snow
2015-04-17 15:11   ` Max Reitz
2015-03-27 19:19 ` [Qemu-devel] [PATCH v2 05/11] block: add transactional callbacks feature John Snow
2015-04-17 15:41   ` Max Reitz
2015-04-17 21:55     ` John Snow
2015-03-27 19:20 ` [Qemu-devel] [PATCH v2 06/11] block: add refcount to Job object John Snow
2015-04-17 15:43   ` Max Reitz
2015-03-27 19:20 ` [Qemu-devel] [PATCH v2 07/11] block: add delayed bitmap successor cleanup John Snow
2015-04-17 15:49   ` Max Reitz
2015-03-27 19:20 ` [Qemu-devel] [PATCH v2 08/11] block: move transactions beneath qmp interfaces John Snow
2015-04-17 16:01   ` Max Reitz
2015-04-17 16:40     ` John Snow
2015-04-17 16:43     ` Eric Blake
2015-03-27 19:20 ` [Qemu-devel] [PATCH v2 09/11] qmp: Add an implementation wrapper for qmp_drive_backup John Snow
2015-04-17 16:12   ` Max Reitz
2015-03-27 19:20 ` [Qemu-devel] [PATCH v2 10/11] block: drive_backup transaction callback support John Snow
2015-04-17 16:55   ` Max Reitz
2015-03-27 19:20 ` [Qemu-devel] [PATCH v2 11/11] iotests: 124 - transactional failure test John Snow
2015-04-17 17:04   ` Max Reitz
2015-04-18  1:01 ` [Qemu-devel] [PATCH v2.5 00/10] block: incremental backup transactions John Snow
2015-04-21 13:53   ` Kashyap Chamarthy
2015-04-21 14:48     ` Kashyap Chamarthy [this message]
2015-04-21 20:33     ` Kashyap Chamarthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150421144850.GH5761@tesla.redhat.com \
    --to=kchamart@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).