From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkvZe-0000Xe-Cw for qemu-devel@nongnu.org; Wed, 22 Apr 2015 10:24:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkvZZ-000227-9h for qemu-devel@nongnu.org; Wed, 22 Apr 2015 10:24:22 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:36861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkvZY-000223-W3 for qemu-devel@nongnu.org; Wed, 22 Apr 2015 10:24:17 -0400 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 22 Apr 2015 15:24:15 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4A2B61B0806B for ; Wed, 22 Apr 2015 15:24:50 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t3MEODSA37027964 for ; Wed, 22 Apr 2015 14:24:13 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t3MEOCGO003539 for ; Wed, 22 Apr 2015 08:24:13 -0600 Date: Wed, 22 Apr 2015 16:24:10 +0200 From: Cornelia Huck Message-ID: <20150422162410.10c36694.cornelia.huck@de.ibm.com> In-Reply-To: <1429613471-7944-2-git-send-email-shannon.zhao@linaro.org> References: <1429613471-7944-1-git-send-email-shannon.zhao@linaro.org> <1429613471-7944-2-git-send-email-shannon.zhao@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: shannon.zhao@linaro.org Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, zhaoshenglong@huawei.com, pbonzini@redhat.com, christoffer.dall@linaro.org On Tue, 21 Apr 2015 18:51:10 +0800 shannon.zhao@linaro.org wrote: I'd drop the leading "hw/net/" from the subject. > From: Shannon Zhao > > Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. > The transports just sync the host features from backend. > Meanwhile move virtio_net_set_config_size to virtio-net. Could you elaborate on why this makes sense? > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/net/virtio-net.c | 5 +++++ > hw/s390x/s390-virtio-bus.c | 2 -- > hw/s390x/virtio-ccw.c | 2 -- > hw/virtio/virtio-pci.c | 2 -- > include/hw/virtio/virtio-net.h | 1 + > 5 files changed, 6 insertions(+), 6 deletions(-) FWIW, this survives basic sanity checks on virtio-ccw - also in combination with my realization sequence reordering patches I sent yesterday. Haven't gotten around to s390-virtio or virtio-scsi yet.