From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlBdS-0003ww-9u for qemu-devel@nongnu.org; Thu, 23 Apr 2015 03:33:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlBdO-0006PI-Hs for qemu-devel@nongnu.org; Thu, 23 Apr 2015 03:33:22 -0400 Date: Thu, 23 Apr 2015 16:04:10 +1000 From: David Gibson Message-ID: <20150423060410.GA26536@voom.redhat.com> References: <1429629131-23800-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: <1429629131-23800-1-git-send-email-thuth@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: aik@ozlabs.ru, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 21, 2015 at 05:12:11PM +0200, Thomas Huth wrote: > The check "liobn & 0xFFFFFFFF00000000ULL" in spapr_tce_find_by_liobn() > is completely useless since liobn is only declared as an uint32_t > parameter. Fix this by using target_ulong instead (this is what most > of the callers of this function are using, too). >=20 > Signed-off-by: Thomas Huth Thanks. Adjusted for a conflict with Alexey's DDW preliminaries and applied to spapr-next. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVOItaAAoJEGw4ysog2bOSCgYP/2SBdm4pYggzrIChm+2TGOGE nfLz1UwkPtgOFfLxJk9ycTzi4tzNrNvMgFTntTtrilSeiqlEQKZOTTtB1jHXxCjh RGRjQl8TdOnBpxzOWGATYZVJoXRTX7FszV1x9uE0V2NZJPSx87Oq59ux7ZImCHe4 9FISUh3tz4fR2nC7wNTVzZYkMCM1mCh+iHKeD8dqf3eKC98ZPIKqJM9zwdKXKdxA nXNo4NCSaRk5z/WRvIcNjUooYcX8htl4YqjJ5PttE5Xeu2F4ioYRTj+vOjkRvUml n3OrokI88aLYW9piZilVb8RUrjA2sHPgp60Ypug0yXp0B67eH84qitj7JJoA0jUm fbui4swGZn/c0TlQFgRVw24PLTOXNM8Yc6JDQWBsxgWGbdM7E93ZHx7fvjjAgB74 e03UjQmM1+328ssRIv7ICioXzkGasfrroV3GolqCMwKVZ2UMlrPYaMYsBrJ1S51y 24v8lD0FREk2cfH6CEv4U809a8AUzRTjNIwl2+Gi3q1xmZ97FLYpWxrGjyxnU7Cv l1QmtYtOzSwAwH0aiMXCqPjlPbgiTpmehNhq5O6+V82qWCVzTWdkmtzhw6vMJQrp irEghvzw3MRFeFGln2HkI/l7nqe3R1HdfL76E9sso1wSoHqljNllui7iT+yAKTk/ /ki3RzdKT8axrWFd0P7R =YjFR -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv--