From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlCoI-0004bt-Gn for qemu-devel@nongnu.org; Thu, 23 Apr 2015 04:48:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlCoF-0001cf-BZ for qemu-devel@nongnu.org; Thu, 23 Apr 2015 04:48:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlCoF-0001ca-68 for qemu-devel@nongnu.org; Thu, 23 Apr 2015 04:48:35 -0400 Date: Thu, 23 Apr 2015 09:48:32 +0100 From: Stefan Hajnoczi Message-ID: <20150423084832.GA8811@stefanha-thinkpad.redhat.com> References: <1426069701-1405-1-git-send-email-den@openvz.org> <1426069701-1405-4-git-send-email-den@openvz.org> <20150422122359.GC27617@stefanha-thinkpad.redhat.com> <5537947A.7050103@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <5537947A.7050103@openvz.org> Subject: Re: [Qemu-devel] [PATCH 03/27] block/parallels: switch to bdrv_read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , Stefan Hajnoczi , qemu-devel@nongnu.org, Roman Kagan --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 22, 2015 at 03:30:50PM +0300, Denis V. Lunev wrote: > On 22/04/15 15:23, Stefan Hajnoczi wrote: > >On Wed, Mar 11, 2015 at 01:27:57PM +0300, Denis V. Lunev wrote: > >>From: Roman Kagan > >> > >>Switch the .bdrv_read method implementation from using bdrv_pread() to > >>bdrv_read() on the underlying file, since the latter is subject to i/o > >>throttling while the former is not. > >> > >>Besides, since bdrv_read() operates in sectors rather than bytes, adjust > >>the helper functions to do so too. > >Can this patch be dropped since "[PATCH 06/27] block/parallels: provide > >_co_readv routine for parallels format driver" switches to > >.bdrv_co_readv() anyway? > > > >Stefan > this is not that easy. This patch changes seek_to_sector call and > in reality to drop it I have to merge patches 3, 4 and 6. > Besides that this patch has been written by my colleague and > I feel comfortable to preserve original Signed-off-by of him. I understand. Stefan --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVOLHgAAoJEJykq7OBq3PIEksIAKX9vzPVrsrxwS45BPRi16b8 2CeWiuetCOY4/VB/8Shg6gWev2+qdSbahFwyfPfDc4SIQNaAYk2LvP+fgERdWFAI +z6dpBwRyL7avjuBa8YG5Jkfxta/RM3YRR7PnI8zZsVVYKTuJKK0wFw48Z4ODWCE 3czTNHgm+GEJlVbt9sjXntTYq7O6Ue9kghPOSg7kahZi1UOcSDwo4odxCoavZ3Sv FH8Q4rHdQrqe1FLq5IYvO7VyeTFaVz27nNkrteIrrM3z3dqxDQ2E38EL5BlQc0e8 IxBQbc9jNG9UVhPhp0upT/QmIcj1CIZijAWXHuJkSCzutBXkdODGAT0TKWLzpNo= =LhdW -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3--