From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlGIW-0000Ah-Ub for qemu-devel@nongnu.org; Thu, 23 Apr 2015 08:32:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlGIS-0004Rf-SV for qemu-devel@nongnu.org; Thu, 23 Apr 2015 08:32:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlGIS-0004RX-LE for qemu-devel@nongnu.org; Thu, 23 Apr 2015 08:32:00 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3NCVxPk024596 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 23 Apr 2015 08:31:59 -0400 Date: Thu, 23 Apr 2015 13:31:54 +0100 From: "Daniel P. Berrange" Message-ID: <20150423123154.GF5845@redhat.com> References: <1429280557-8887-1-git-send-email-berrange@redhat.com> <1429280557-8887-24-git-send-email-berrange@redhat.com> <1429514329.12547.16.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1429514329.12547.16.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH v1 RFC 23/34] io: add QIOChannelSocket class Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Paolo Bonzini , qemu-devel@nongnu.org, Stefan Hajnoczi On Mon, Apr 20, 2015 at 09:18:49AM +0200, Gerd Hoffmann wrote: > On Fr, 2015-04-17 at 15:22 +0100, Daniel P. Berrange wrote: > > Implement a QIOChannel subclass that supports sockets I/O > > > > TBD check errno handling of windows port & fix watch impl > > > +struct QIOChannelSocket { > > + QIOChannel parent; > > + int fd; > > + struct sockaddr_storage localAddr; > > + socklen_t localAddrLen; > > + struct sockaddr_storage remoteAddr; > > + socklen_t remoteAddrLen; > > +}; > > Looks like this supports a single listening socket only, correct? That > is a long-standing issue we have in qemu. Listening on both ipv4 and > ipv6 doesn't work, except when binding the socket to the ipv6 wildcard > address which can accept ipv4 connects too on most systems. > > Would be nice to tackle that while putting the socket code upside down > anyway. Thanks for reminding me about this limitation - I'll have a think about how we can solve this problem at the same time too. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|