From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlHMM-0006Rp-FD for qemu-devel@nongnu.org; Thu, 23 Apr 2015 09:40:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlHML-000805-NO for qemu-devel@nongnu.org; Thu, 23 Apr 2015 09:40:06 -0400 Date: Thu, 23 Apr 2015 14:39:56 +0100 From: Stefan Hajnoczi Message-ID: <20150423133956.GD20959@stefanha-thinkpad.redhat.com> References: <1429314609-29776-1-git-send-email-jsnow@redhat.com> <1429314609-29776-7-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mJm6k4Vb/yFcL9ZU" Content-Disposition: inline In-Reply-To: <1429314609-29776-7-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v6 06/21] hbitmap: cache array lengths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, mreitz@redhat.com --mJm6k4Vb/yFcL9ZU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 17, 2015 at 07:49:54PM -0400, John Snow wrote: > As a convenience: between incremental backups, bitmap migrations > and bitmap persistence we seem to need to recalculate these a lot. >=20 > Because the lengths are a little bit-twiddly, let's just solidly > cache them and be done with it. >=20 > Reviewed-by: Max Reitz > Reviewed-by: Eric Blake > Signed-off-by: John Snow > --- > util/hbitmap.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Stefan Hajnoczi --mJm6k4Vb/yFcL9ZU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVOPYsAAoJEJykq7OBq3PIz0UH/3TyvOGOCiKatgOWwMszMLSn GcxkF/0KMsO22+8CD6DqPDiBZndlXg526c7alxVTQGvP8z7ozACnvZB7Rjwfe4i1 H28zFhlMFhkcmZWACyw8aV4f9xrL8JyycZANrtCdqVtmimEZ4yRAcrf2dEh+8lGV KTfvLSXVa3Cd/Qs4q2UEl3miVpWN1lnlsF/693gQokHlMdvlm+sxSVKHDqnr9MhD qggV/KiXSD2KbYuC9+h6ayQwmRmWaFH+OHt2Ux5t5Tz+a8TBF3fBzfEQNRLW0Aof on+DD9t2x12hGnhqPavDPz9KM+R1vjL1i6zIZGs3yHhlsaH+QynAKC3V3/mqGNY= =kpKq -----END PGP SIGNATURE----- --mJm6k4Vb/yFcL9ZU--