Re: [Qemu-devel] [PATCH v2 0/7] Remove more unused functions

Re: [Qemu-devel] [PATCH v2 0/7] Remove more unused functions

[Thomas Huth]

Am Wed, 18 Mar 2015 12:22:35 +0100
schrieb Thomas Huth <thuth@linux.vnet.ibm.com>:

> 
> Here are some more patches to remove completely unused functions
> from QEMU. Please review carefully, some of the functions might
> still get usefull in the future again, so if you discover one,
> please let me know, then I'll remove it from the patch series
> again.
> 
> v2: Changed series according to review comment from v1:
> - Dropped the patch to remove portio_list_destroy() and
> portio_list_del()
> - Keep the ARI functions in the pci patch since they might get useful
> again
> 
> Thomas Huth (7):
>   migration: Remove unused functions
>   vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags()
>   pci: Remove unused function ich9_d2pbr_init()
>   monitor: Remove unused functions
>   usb: Remove unused functions
>   util: Remove unused functions
>   Remove various unused functions

Ping! Now that 2.3.0 (congrats!) has been tagged, could somebody
(Michael via qemu-trivial tree?) please pick up patches 2 to 7? As far
as I know, there haven't been any complaints about them anymore, so I
think it should be ok to include them.
(patch 1 has already been included via the migration tree, so that's
already fine)

 Cheers,
  Thomas

Re: [Qemu-devel] [PATCH v2 0/7] Remove more unused functions

[Thomas Huth]

> Date: Mon, 27 Apr 2015 20:09:50 +0200
> From: Stefan Weil <sw@weilnetz.de>
> 
> Am 27.04.2015 um 13:27 schrieb Michael Tokarev:
> > 14.03.2015 09:19, Thomas Huth wrote:
> >> Here are some more patches to remove completely unused functions
> >> from QEMU. Please review carefully, some of the functions might
> >> still get usefull in the future again, so if you discover one,
> >> please let me know, then I'll remove it from the patch series
> >> again.
> > Applied to -trivial, thank you!
> >
> > /mjt
> 
> I'm sorry that I did not notice this series earlier.
> 
> The function serial_set_frequency() is used in my personal branch for 
> MIPS AR7.

Ok, since this function still could be again useful in the future,
could you simply drop the related patch from your queue again, Michael?
(or just drop the related hunks in the patch if you've got some spare
time to rework it? If not, I could do that at a later point in time and
send a new patch).

 Thanks,
  Thomas

Re: [Qemu-devel] [PATCH v2 0/7] Remove more unused functions

[Michael Tokarev]

28.04.2015 09:38, Thomas Huth wrote:
>> Date: Mon, 27 Apr 2015 20:09:50 +0200
>> From: Stefan Weil <sw@weilnetz.de>
>>
>> Am 27.04.2015 um 13:27 schrieb Michael Tokarev:
>>> 14.03.2015 09:19, Thomas Huth wrote:
>>>> Here are some more patches to remove completely unused functions
>>>> from QEMU. Please review carefully, some of the functions might
>>>> still get usefull in the future again, so if you discover one,
>>>> please let me know, then I'll remove it from the patch series
>>>> again.
>>> Applied to -trivial, thank you!
>>>
>> I'm sorry that I did not notice this series earlier.
>>
>> The function serial_set_frequency() is used in my personal branch for 
>> MIPS AR7.
> 
> Ok, since this function still could be again useful in the future,
> could you simply drop the related patch from your queue again, Michael?
> (or just drop the related hunks in the patch if you've got some spare
> time to rework it? If not, I could do that at a later point in time and
> send a new patch).

Piggy-back.  Oh well :)

I removed the patch named "Remove various unused functions" for now.
Because if I'll try to edit it, it'll be difficult for me to retain
your s-o-b.

You can resend this one with the right set of functions being removed.

Thanks,

/mjt

[Qemu-devel] [PATCH v2 0/7] Remove more unused functions

[Thomas Huth]

Here are some more patches to remove completely unused functions
from QEMU. Please review carefully, some of the functions might
still get usefull in the future again, so if you discover one,
please let me know, then I'll remove it from the patch series
again.

v2: Changed series according to review comment from v1:
- Dropped the patch to remove portio_list_destroy() and portio_list_del()
- Keep the ARI functions in the pci patch since they might get useful again

Thomas Huth (7):
  migration: Remove unused functions
  vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags()
  pci: Remove unused function ich9_d2pbr_init()
  monitor: Remove unused functions
  usb: Remove unused functions
  util: Remove unused functions
  Remove various unused functions

 backends/tpm.c                   |   11 ------
 hmp.h                            |    1 -
 hw/char/serial.c                 |    7 ----
 hw/net/vmxnet_rx_pkt.c           |    7 ----
 hw/net/vmxnet_rx_pkt.h           |    9 -----
 hw/pci-bridge/i82801b11.c        |   21 ------------
 hw/usb/core.c                    |   41 -----------------------
 include/hw/char/serial.h         |    1 -
 include/hw/i386/ich9.h           |    1 -
 include/hw/usb.h                 |    5 ---
 include/migration/migration.h    |    1 -
 include/migration/qemu-file.h    |    2 -
 include/monitor/monitor.h        |    1 -
 include/qemu-common.h            |    4 --
 include/qemu/compatfd.h          |    1 -
 include/sysemu/iothread.h        |    1 -
 include/sysemu/tpm_backend_int.h |    2 -
 iothread.c                       |   12 -------
 migration/migration.c            |    9 -----
 migration/qemu-file-buf.c        |   53 ------------------------------
 monitor.c                        |   13 -------
 util/compatfd.c                  |   19 -----------
 util/osdep.c                     |   66 --------------------------------------
 23 files changed, 0 insertions(+), 288 deletions(-)

Re: [Qemu-devel] [PATCH v2 0/7] Remove more unused functions

[Michael Tokarev]

14.03.2015 09:19, Thomas Huth wrote:
> Here are some more patches to remove completely unused functions
> from QEMU. Please review carefully, some of the functions might
> still get usefull in the future again, so if you discover one,
> please let me know, then I'll remove it from the patch series
> again.

Applied to -trivial, thank you!

/mjt

Re: [Qemu-devel] [PATCH v2 0/7] Remove more unused functions

[Stefan Weil]

Am 27.04.2015 um 13:27 schrieb Michael Tokarev:
> 14.03.2015 09:19, Thomas Huth wrote:
>> Here are some more patches to remove completely unused functions
>> from QEMU. Please review carefully, some of the functions might
>> still get usefull in the future again, so if you discover one,
>> please let me know, then I'll remove it from the patch series
>> again.
> Applied to -trivial, thank you!
>
> /mjt


I'm sorry that I did not notice this series earlier.

The function serial_set_frequency() is used in my personal branch for 
MIPS AR7. That's not a sufficient reason to keep it, but I think that 
other (maybe most) systems have a serial clock with a typical frequency 
which can be changed by software (as it is the case for AR7). So if this 
function is currently unused, this simply means that the serial device 
emulations are incomplete.

Regards
Stefan