From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
alex.bennee@linaro.org, mark.burton@greensocs.com,
real@ispras.ru, batuzovk@ispras.ru,
maria.klimushenkova@ispras.ru, pavel.dovgaluk@ispras.ru,
pbonzini@redhat.com, fred.konrad@greensocs.com
Subject: [Qemu-devel] [RFC PATCH v11 09/23] i386: interrupt poll processing
Date: Mon, 27 Apr 2015 10:33:05 +0300 [thread overview]
Message-ID: <20150427073304.9264.11504.stgit@PASHA-ISP> (raw)
In-Reply-To: <20150427073208.9264.80349.stgit@PASHA-ISP>
This patch updates x86_cpu_exec_interrupt function.
It can process two interrupt request at a time (poll and another one).
This makes its execution non-deterministic. Determinism is requred
for recorded icount execution.
Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
target-i386/seg_helper.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c
index 2bc757a..92a49b3 100644
--- a/target-i386/seg_helper.c
+++ b/target-i386/seg_helper.c
@@ -1294,6 +1294,9 @@ bool x86_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
if (interrupt_request & CPU_INTERRUPT_POLL) {
cs->interrupt_request &= ~CPU_INTERRUPT_POLL;
apic_poll_irq(cpu->apic_state);
+ /* Don't process multiple interrupt requests in a single call.
+ This is required to make icount-driven execution deterministic. */
+ return true;
}
#endif
if (interrupt_request & CPU_INTERRUPT_SIPI) {
next prev parent reply other threads:[~2015-04-27 7:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 7:32 [Qemu-devel] [RFC PATCH v11 00/23] Deterministic replay core Pavel Dovgalyuk
2015-04-27 7:32 ` [Qemu-devel] [RFC PATCH v11 01/23] i386: partial revert of interrupt poll fix Pavel Dovgalyuk
2015-04-27 7:32 ` [Qemu-devel] [RFC PATCH v11 02/23] replay: global variables and function stubs Pavel Dovgalyuk
2015-04-27 7:32 ` [Qemu-devel] [RFC PATCH v11 03/23] sysemu: system functions for replay Pavel Dovgalyuk
2015-04-27 7:32 ` [Qemu-devel] [RFC PATCH v11 04/23] replay: internal functions for replay log Pavel Dovgalyuk
2015-04-27 7:32 ` [Qemu-devel] [RFC PATCH v11 05/23] replay: introduce mutex to protect the " Pavel Dovgalyuk
2015-04-27 7:32 ` [Qemu-devel] [RFC PATCH v11 06/23] replay: introduce icount event Pavel Dovgalyuk
2015-04-27 7:32 ` [Qemu-devel] [RFC PATCH v11 07/23] cpu-exec: allow temporary disabling icount Pavel Dovgalyuk
2015-04-27 7:32 ` [Qemu-devel] [RFC PATCH v11 08/23] cpu: replay instructions sequence Pavel Dovgalyuk
2015-04-27 7:33 ` Pavel Dovgalyuk [this message]
2015-04-27 7:33 ` [Qemu-devel] [RFC PATCH v11 10/23] replay: interrupts and exceptions Pavel Dovgalyuk
2015-04-27 7:33 ` [Qemu-devel] [RFC PATCH v11 11/23] replay: asynchronous events infrastructure Pavel Dovgalyuk
2015-04-27 7:33 ` [Qemu-devel] [RFC PATCH v11 12/23] replay: recording and replaying clock ticks Pavel Dovgalyuk
2015-04-27 7:33 ` [Qemu-devel] [RFC PATCH v11 13/23] replay: shutdown event Pavel Dovgalyuk
2015-04-27 7:33 ` [Qemu-devel] [RFC PATCH v11 14/23] replay: checkpoints Pavel Dovgalyuk
2015-04-27 7:33 ` [Qemu-devel] [RFC PATCH v11 15/23] aio: replace stack of bottom halves with queue Pavel Dovgalyuk
2015-04-27 7:33 ` [Qemu-devel] [RFC PATCH v11 16/23] replay: bottom halves Pavel Dovgalyuk
2015-04-27 7:33 ` [Qemu-devel] [RFC PATCH v11 17/23] replay: replay aio requests Pavel Dovgalyuk
2015-04-27 7:33 ` [Qemu-devel] [RFC PATCH v11 18/23] replay: thread pool Pavel Dovgalyuk
2015-04-27 7:34 ` [Qemu-devel] [RFC PATCH v11 19/23] typedef: add typedef for QemuOpts Pavel Dovgalyuk
2015-04-27 7:34 ` [Qemu-devel] [RFC PATCH v11 20/23] replay: initialization and deinitialization Pavel Dovgalyuk
2015-04-27 7:34 ` [Qemu-devel] [RFC PATCH v11 21/23] replay: replay blockers for devices Pavel Dovgalyuk
2015-04-27 7:34 ` [Qemu-devel] [RFC PATCH v11 22/23] replay: command line options Pavel Dovgalyuk
2015-04-27 7:34 ` [Qemu-devel] [RFC PATCH v11 23/23] replay: recording of the user input Pavel Dovgalyuk
2015-04-30 15:30 ` [Qemu-devel] [RFC PATCH v11 00/23] Deterministic replay core Paolo Bonzini
2015-05-05 8:46 ` Pavel Dovgaluk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150427073304.9264.11504.stgit@PASHA-ISP \
--to=pavel.dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=batuzovk@ispras.ru \
--cc=fred.konrad@greensocs.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mark.burton@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=real@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).