From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmhwE-0003bu-8P for qemu-devel@nongnu.org; Mon, 27 Apr 2015 08:15:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmhwA-0006Qz-6R for qemu-devel@nongnu.org; Mon, 27 Apr 2015 08:15:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymhw9-0006Qo-VW for qemu-devel@nongnu.org; Mon, 27 Apr 2015 08:14:58 -0400 Date: Mon, 27 Apr 2015 14:14:10 +0200 From: "Michael S. Tsirkin" Message-ID: <20150427141221-mutt-send-email-mst@redhat.com> References: <1426791181-23831-1-git-send-email-marcel@redhat.com> <1426791181-23831-14-git-send-email-marcel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426791181-23831-14-git-send-email-marcel@redhat.com> Subject: Re: [Qemu-devel] [PATCH V6 for-2.3 13/26] hw/pci-host: introduce TYPE_PCI_HOST_BRIDGE_SNOOPED interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: kraxel@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, alex.williamson@redhat.com, kevin@koconnor.net, hare@suse.de, imammedo@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net On Thu, Mar 19, 2015 at 08:52:48PM +0200, Marcel Apfelbaum wrote: > TYPE_PCI_HOST_BRIDGE_SNOOPED is a special case of host bridge > whose configuration registers are snooped by other host bridges > to complete their configuration cycles. > > The interface exposes a list of snooping host bridges that > shall be used by the hosts implementing this interface > in order to emulate a snooping mechanism. > > The way that the snooping hosts are registered or how > the snooping is implemented are out of the interface scope, > it only provides a way to determine if a host bridge has > snooping hosts and list them. > Signed-off-by: Marcel Apfelbaum > --- > hw/pci/pci_host.c | 8 ++++++++ > include/hw/pci/pci_host.h | 24 ++++++++++++++++++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c > index 87180c8..288e74c 100644 > --- a/hw/pci/pci_host.c > +++ b/hw/pci/pci_host.c > @@ -180,6 +180,12 @@ static const TypeInfo pci_main_host_interface_info = { > .parent = TYPE_INTERFACE, > }; > > +static const TypeInfo pci_host_bridge_snooped_interface_info = { > + .name = TYPE_PCI_HOST_BRIDGE_SNOOPED, > + .parent = TYPE_INTERFACE, > + .class_size = sizeof(PCIHostBridgeSnoopedClass), > +}; > + > static const TypeInfo pci_host_type_info = { > .name = TYPE_PCI_HOST_BRIDGE, > .parent = TYPE_SYS_BUS_DEVICE, > @@ -191,7 +197,9 @@ static const TypeInfo pci_host_type_info = { > static void pci_host_register_types(void) > { > type_register_static(&pci_main_host_interface_info); > + type_register_static(&pci_host_bridge_snooped_interface_info); > type_register_static(&pci_host_type_info); > + extra empty line > } > > type_init(pci_host_register_types) > diff --git a/include/hw/pci/pci_host.h b/include/hw/pci/pci_host.h > index 3c72e26..a041919 100644 > --- a/include/hw/pci/pci_host.h > +++ b/include/hw/pci/pci_host.h > @@ -63,6 +63,30 @@ typedef struct PCIHostBridgeClass { > const char *(*root_bus_path)(PCIHostState *, PCIBus *); > } PCIHostBridgeClass; > > +/** > + * A special case of host bridge whose configuration registers > + * are snooped by other host bridges to complete their > + * configuration cycles. > + */ > +#define TYPE_PCI_HOST_BRIDGE_SNOOPED "pci-host-bridge-snooped" > +#define TYPE_PCI_HOST_BRIDGE_SNOOPED_CLASS(klass) \ > + OBJECT_CLASS_CHECK(PCIHostBridgeSnoopedClass, (klass), \ > + TYPE_PCI_HOST_BRIDGE_SNOOPED) > +#define PCI_HOST_BRIDGE_SNOOPED_GET_CLASS(obj) \ > + OBJECT_GET_CLASS(PCIHostBridgeSnoopedClass, (obj), \ > + TYPE_PCI_HOST_BRIDGE_SNOOPED) > +#define PCI_HOST_BRIDGE_SNOOPED(obj) \ > + INTERFACE_CHECK(PCIHostState, (obj), \ > + TYPE_PCI_HOST_BRIDGE_SNOOPED) > + > +typedef struct PCIHostBridgeSnoopedClass { > + /* */ > + InterfaceClass parent_class; > + > + /* */ > + GPtrArray *(*snooping_hosts)(PCIHostState *); Why not just add GPtrArray here directly, and add an API to register/deregister? > +} PCIHostBridgeSnoopedClass; > + > /* common internal helpers for PCI/PCIe hosts, cut off overflows */ > void pci_host_config_write_common(PCIDevice *pci_dev, uint32_t addr, > uint32_t limit, uint32_t val, uint32_t len); > -- > 2.1.0