From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49090)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Ymi63-0006Hg-2P
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 08:25:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Ymi5y-0004Ey-2u
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 08:25:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40950)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Ymi5x-0004Cl-SQ
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 08:25:06 -0400
Date: Mon, 27 Apr 2015 14:24:44 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150427142407-mutt-send-email-mst@redhat.com>
References: <1426791181-23831-1-git-send-email-marcel@redhat.com>
	<1426791181-23831-10-git-send-email-marcel@redhat.com>
	<20150427130801-mutt-send-email-mst@redhat.com>
	<553E1F17.3030302@redhat.com> <553E223C.3020005@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <553E223C.3020005@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V6 for-2.3 09/26] hw/pci: move pci bus
 related code to separate files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, alex.williamson@redhat.com, kevin@koconnor.net, kraxel@redhat.com, imammedo@redhat.com, amit.shah@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, hare@suse.de

On Mon, Apr 27, 2015 at 02:49:16PM +0300, Marcel Apfelbaum wrote:
> On 04/27/2015 02:35 PM, Paolo Bonzini wrote:
> >
> >On 27/04/2015 13:14, Michael S. Tsirkin wrote:
> >>>+ *
> >>>>+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
> >>>>+ * See the COPYING file in the top-level directory.
> >>The file you are moving this from is GPL only.
> >
> >It's BSD.
> >
> >>You will need to find who contributed this code you are moving
> >>and get ack from them ...
> >
> >Simpler to keep BSD.
> Sure, will do.
> 
> Thanks,
> Marcel

I'd say just keep it within pci.c for now, the smaller the patchset the
better. Refactor later.

> >
> >Paolo
> >