From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40310)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YmkuP-0004Fs-Fw
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 11:25:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YmkuL-00064r-Bx
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 11:25:21 -0400
Date: Mon, 27 Apr 2015 17:25:04 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150427152504.GF4046@noname.str.redhat.com>
References: <1430132851-26073-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1430132851-26073-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/mirror: Always call
	block_job_sleep_ns()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org

Am 27.04.2015 um 13:07 hat Max Reitz geschrieben:
> The mirror block job is trying to take a clever shortcut if delay_ns is
> 0 and skips block_job_sleep_ns() in that case. But that function must be
> called in every block job iteration, because otherwise it is for example
> impossible to pause the job.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> This makes test 129 pass when run in tmpfs (for me, at least).

Thanks, applied to the block branch.

Kevin