From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45718)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1Yml7s-0007py-Hw
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 11:39:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1Yml7p-0003tP-At
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 11:39:16 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41216)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1Yml7p-0003tI-7Q
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 11:39:13 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
	by mailout.nyi.internal (Postfix) with ESMTP id 7D86220093
	for <qemu-devel@nongnu.org>; Mon, 27 Apr 2015 11:39:12 -0400 (EDT)
Date: Mon, 27 Apr 2015 11:39:46 -0400
From: "Emilio G. Cota" <cota@braap.org>
Message-ID: <20150427153946.GA25629@flamenco>
References: <1430085867-22514-1-git-send-email-cota@braap.org>
	<CAEgOgz6eW5uULkBaw_Stco4uTwVAvrBKKOH3Utebc4v6Vp+TfQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEgOgz6eW5uULkBaw_Stco4uTwVAvrBKKOH3Utebc4v6Vp+TfQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Laszlo Ersek <lersek@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

On Sun, Apr 26, 2015 at 19:18:41 -0700, Peter Crosthwaite wrote:
> On Sun, Apr 26, 2015 at 3:04 PM, Emilio G. Cota <cota@braap.org> wrote:
> > It's defined in osdep.h and shouldn't be redefined here.
> >
> > Signed-off-by: Emilio G. Cota <cota@braap.org>
> 
> 
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

Thanks for having a look!

> It looks like there may be another one too:
> 
> hw/audio/fmopl.c:#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

That one is protected by #ifndef ARRAY_SIZE and AFAICT the file does not
include any qemu headers, so we can safely leave it as is.

		Emilio