From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymlik-0003ci-Q4 for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:17:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ymlih-0004m2-Kq for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:17:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymlih-0004lo-G1 for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:17:19 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 1C33FC1EFE for ; Mon, 27 Apr 2015 16:17:18 +0000 (UTC) Date: Mon, 27 Apr 2015 18:17:16 +0200 From: "Michael S. Tsirkin" Message-ID: <20150427181629-mutt-send-email-mst@redhat.com> References: <1430133591-6197-1-git-send-email-ghammer@redhat.com> <1430133591-6197-6-git-send-email-ghammer@redhat.com> <553E4F50.4030301@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <553E4F50.4030301@redhat.com> Subject: Re: [Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Gal Hammer , imammedo@redhat.com, qemu-devel@nongnu.org On Mon, Apr 27, 2015 at 09:01:36AM -0600, Eric Blake wrote: > On 04/27/2015 05:19 AM, Gal Hammer wrote: > > Signed-off-by: Gal Hammer > > Subject line: Most commits do NOT end in a trailing '.'. It's less > obvious if there is a preference for starting commits with a capital > after the subject, but that seems to be the current prevailing trend. I personally prefer all-lower-case subjects. In particular upper case after : is just weird. > So I might have done: > > tests: Add a unit test for vmgenid device > > or even: > > vmgenid: Add a unit test > > (the latter approach would mean grouping all of the series under a > single topic of vmgenid, instead of your approach of a different topic > per patch according to which part was being modified in support of > adding vmgenid. Either approach is fine by me) > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >