From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn02t-0001VE-Ib for qemu-devel@nongnu.org; Tue, 28 Apr 2015 03:35:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn02p-0006ca-99 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 03:35:07 -0400 Date: Tue, 28 Apr 2015 17:31:03 +1000 From: David Gibson Message-ID: <20150428073103.GD24753@voom.redhat.com> References: <1429684100-13354-1-git-send-email-mdroth@linux.vnet.ibm.com> <1429684100-13354-15-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yudcn1FV7Hsu/q59" Content-Disposition: inline In-Reply-To: <1429684100-13354-15-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v8 14/16] pci: make pci_bar useable outside pci.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: mst@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --yudcn1FV7Hsu/q59 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 22, 2015 at 01:28:18AM -0500, Michael Roth wrote: > We need to work with PCI BARs to generate OF properties > during PCI hotplug for sPAPR guests. >=20 > Signed-off-by: Michael Roth > Reviewed-by: David Gibson > Cc: mst@redhat.com Michael Tsirkin, Interested to see your comment on this. Are you ok with this? Can you take this through your tree? Because it affects general PCI code, I'm not really comfortable merging this through my spapr-next tree, which is where I plan to put all the rest. > --- > hw/pci/pci.c | 2 +- > include/hw/pci/pci.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 6941a82..7d14657 100644 > --- a/hw/pci/pci.c > +++ b/hw/pci/pci.c > @@ -123,7 +123,7 @@ static uint16_t pci_default_sub_device_id =3D PCI_SUB= DEVICE_ID_QEMU; > =20 > static QLIST_HEAD(, PCIHostState) pci_host_bridges; > =20 > -static int pci_bar(PCIDevice *d, int reg) > +int pci_bar(PCIDevice *d, int reg) > { > uint8_t type; > =20 > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index be2d9b8..1a4e0be 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -332,6 +332,7 @@ void pci_device_save(PCIDevice *s, QEMUFile *f); > int pci_device_load(PCIDevice *s, QEMUFile *f); > MemoryRegion *pci_address_space(PCIDevice *dev); > MemoryRegion *pci_address_space_io(PCIDevice *dev); > +int pci_bar(PCIDevice *d, int reg); > =20 > typedef void (*pci_set_irq_fn)(void *opaque, int irq_num, int level); > typedef int (*pci_map_irq_fn)(PCIDevice *pci_dev, int irq_num); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yudcn1FV7Hsu/q59 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVPzc3AAoJEGw4ysog2bOShYoQANX1GBYGEXC+0KSjPeLP1FVp M/cOOLIj5ZwE0m6W2GNdj0GLRwCgtVkI+Se3arwHdUFb0vKXt1Gozws/UXaQJcrW 9olXc/LL4hU8cc31ov6KALevcXKushG9ATkFTLIXzoZCWsTQdMKNxe2wy1O8Ruec VG2McXkAV1Nv/5MvbpxFW/jOL9nVOIkhrLEMfzD4NiqFOBenG5Ho/bWzXSyBA5O0 gH9nahIzZ7qSaMcl0psgCkg7J/v3vW655jVrnNG5WydYHHJu4JgPBP3u7Bp79gmK 2EfHoRfQcfUH45vH2/qtMIDppStz1GK6tUX357W/uVhWrZVYxGcJRYccEYw1I4VE UzYVFmgwPwW3EuyBd2P8yufmYkD9yjSz3KrkfDG1Jew1Z2cGaSsqV5slJNFypnQE nnfefZDar/PydFldxdcI052SA/ZBXu0Npx6KgkrM5cjJcBeysZNf6fVbjGsoKe6R eluWP2KxG9ePqCofguZQYZM0s+Bvl2/PAZ4BumjLAjCF48TJUVuj9+FR3klQbhw9 46Sv4k9kBhFS0X4klaBQEhqc9937cYK/Vdk4A5CYT8UrIkP79yj8NPQmx8R57dme ByHTkN2JRRQNOGQU4FWXpMi9IrPri8OpJaw5k7XfxkVeDBcuac47XyHHGOZI2Rhk ptYD5vqNrZb7OwRqHZTu =MydW -----END PGP SIGNATURE----- --yudcn1FV7Hsu/q59--