From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymzju-0001R9-GY for qemu-devel@nongnu.org; Tue, 28 Apr 2015 03:15:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ymzjr-0004jP-43 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 03:15:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymzjq-0004j6-Pf for qemu-devel@nongnu.org; Tue, 28 Apr 2015 03:15:27 -0400 Date: Tue, 28 Apr 2015 09:15:14 +0200 From: "Michael S. Tsirkin" Message-ID: <20150428091443-mutt-send-email-mst@redhat.com> References: <1429613471-7944-1-git-send-email-shannon.zhao@linaro.org> <1429613471-7944-3-git-send-email-shannon.zhao@linaro.org> <553ED515.400@linaro.org> <20150428075441-mutt-send-email-mst@redhat.com> <553F28F9.1040503@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <553F28F9.1040503@huawei.com> Subject: Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, Shannon Zhao , cornelia.huck@de.ibm.com, pbonzini@redhat.com, christoffer.dall@linaro.org On Tue, Apr 28, 2015 at 02:30:17PM +0800, Shannon Zhao wrote: > On 2015/4/28 13:55, Michael S. Tsirkin wrote: > > Pong. > > You responded to Cornelia's comments on patch 1/2 > > with "ok will add". > > I expected v4. > > > > Yeah, but few comments on this patch, so I just want to confirm this > modification is acceptable to virtio-scsi, then will modify the commit > log and send v4. My question would be, why just net and scsi? Does not the same apply to all devices? > > On Tue, Apr 28, 2015 at 08:32:21AM +0800, Shannon Zhao wrote: > >> Ping? > >> > >> On 2015/4/21 18:51, shannon.zhao@linaro.org wrote: > >>> From: Shannon Zhao > >>> > >>> Move DEFINE_VIRTIO_SCSI_FEATURES to the backend virtio-scsi. > >>> The transports just sync the host features from backend. > >>> > >>> Signed-off-by: Shannon Zhao > >>> Signed-off-by: Shannon Zhao > >>> --- > >>> hw/s390x/s390-virtio-bus.c | 1 - > >>> hw/s390x/virtio-ccw.c | 1 - > >>> hw/scsi/virtio-scsi.c | 5 +++++ > >>> hw/virtio/virtio-pci.c | 1 - > >>> include/hw/virtio/virtio-scsi.h | 1 + > >>> 5 files changed, 6 insertions(+), 3 deletions(-) > >> > >> -- > >> Shannon > > > > . > > >