From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn0ui-0006LJ-Ha for qemu-devel@nongnu.org; Tue, 28 Apr 2015 04:30:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn0ud-0003pn-Fl for qemu-devel@nongnu.org; Tue, 28 Apr 2015 04:30:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn0uc-0003pW-Pl for qemu-devel@nongnu.org; Tue, 28 Apr 2015 04:30:39 -0400 Date: Tue, 28 Apr 2015 10:30:14 +0200 From: "Michael S. Tsirkin" Message-ID: <20150428102804-mutt-send-email-mst@redhat.com> References: <1426791181-23831-1-git-send-email-marcel@redhat.com> <1426791181-23831-10-git-send-email-marcel@redhat.com> <20150427130801-mutt-send-email-mst@redhat.com> <553E2B04.8030703@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <553E2B04.8030703@redhat.com> Subject: Re: [Qemu-devel] [PATCH V6 for-2.3 09/26] hw/pci: move pci bus related code to separate files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: kraxel@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, alex.williamson@redhat.com, kevin@koconnor.net, hare@suse.de, imammedo@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net On Mon, Apr 27, 2015 at 03:26:44PM +0300, Marcel Apfelbaum wrote: > On 04/27/2015 02:14 PM, Michael S. Tsirkin wrote: > >On Thu, Mar 19, 2015 at 08:52:44PM +0200, Marcel Apfelbaum wrote: > >>@@ -2414,7 +1945,6 @@ static const TypeInfo pci_device_type_info = { > >> > >> static void pci_register_types(void) > >> { > >>- type_register_static(&pci_bus_info); > >> type_register_static(&pcie_bus_info); > >> type_register_static(&pci_device_type_info); > >> } > > > >So pcie bus is not moved. This seems pretty inconsistent. > There were a lot of code dependencies. I moved the minimum code in order > to be able to add code specific to PCIBus. Interfaces need to make sense, this one feels like you randomly moved out parts that your patch happens to need. Just keep it all in pci.c for now. -- MST