From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnA2B-0006hH-TI for qemu-devel@nongnu.org; Tue, 28 Apr 2015 14:15:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnA28-0005h2-I5 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 14:15:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnA28-0005gx-9A for qemu-devel@nongnu.org; Tue, 28 Apr 2015 14:15:00 -0400 Date: Tue, 28 Apr 2015 20:14:44 +0200 From: "Michael S. Tsirkin" Message-ID: <20150428201255-mutt-send-email-mst@redhat.com> References: <1430221873-5788-1-git-send-email-shannon.zhao@linaro.org> <20150428151249-mutt-send-email-mst@redhat.com> <20150428152419.67bc77b1.cornelia.huck@de.ibm.com> <20150428160354-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150428160354-mutt-send-email-mst@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Peter Maydell , hangaohuai@huawei.com, "Huangpeng (Peter)" , QEMU Developers , Shannon Zhao , Shannon Zhao , Paolo Bonzini , Christoffer Dall On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote: > > On Tue, 28 Apr 2015 14:16:40 +0100 > > Peter Maydell wrote: > > > > > On 28 April 2015 at 14:13, Michael S. Tsirkin wrote: > > > > The patches look correct to me too, but I want s390 > > > > cleaned up so it does not include COMMON_FEATURES > > > > in 100 places, and I prefer merging it all together. > > > > > > It seems a bit harsh to ask Shannon to do s390 cleanup when > > > he doesn't have any access to s390 guests or test cases... > > > Making S390 put COMMON_FEATURES in the right places seems > > > to me like a separate bit of s390-specific cleanup. > > > > Yep, see my other reply... I'm not quite sure what's wrong with > > event_idx on virtio-blk for s390-virtio, or I would gladly make this > > consistent with the other transports. Any hints appreciated :) > > Is this still happening? > > It is possible that what was missing was > 92045d80badc43c9f95897aad675dc7ef17a3b3f > and/or > a281ebc11a6917fbc27e1a93bb5772cd14e241fc > Found this: http://thread.gmane.org/gmane.comp.emulators.qemu/280334/focus=280357 so it's unlikely: these commits are from 2012, you saw issues in 2014. We really need to fix it. virtio 1 work will be much easier if we can just move features into virtio dev. > -- > MST