From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnAPW-0000Sj-R2 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 14:39:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnAPR-0004fU-Np for qemu-devel@nongnu.org; Tue, 28 Apr 2015 14:39:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnAPR-0004fL-Er for qemu-devel@nongnu.org; Tue, 28 Apr 2015 14:39:05 -0400 Date: Tue, 28 Apr 2015 20:38:52 +0200 From: "Michael S. Tsirkin" Message-ID: <20150428203619-mutt-send-email-mst@redhat.com> References: <1430221873-5788-1-git-send-email-shannon.zhao@linaro.org> <20150428151249-mutt-send-email-mst@redhat.com> <20150428152419.67bc77b1.cornelia.huck@de.ibm.com> <20150428160354-mutt-send-email-mst@redhat.com> <20150428201255-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: hangaohuai@huawei.com, "Huangpeng (Peter)" , QEMU Developers , Shannon Zhao , Shannon Zhao , Cornelia Huck , Paolo Bonzini , Christoffer Dall On Tue, Apr 28, 2015 at 07:34:29PM +0100, Peter Maydell wrote: > On 28 April 2015 at 19:14, Michael S. Tsirkin wrote: > > On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote: > >> On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote: > >> > Yep, see my other reply... I'm not quite sure what's wrong with > >> > event_idx on virtio-blk for s390-virtio, or I would gladly make this > >> > consistent with the other transports. Any hints appreciated :) > >> > >> Is this still happening? > >> > >> It is possible that what was missing was > >> 92045d80badc43c9f95897aad675dc7ef17a3b3f > >> and/or > >> a281ebc11a6917fbc27e1a93bb5772cd14e241fc > >> > > > > Found this: > > http://thread.gmane.org/gmane.comp.emulators.qemu/280334/focus=280357 > > so it's unlikely: these commits are from 2012, you saw > > issues in 2014. > > > > We really need to fix it. virtio 1 work will be much easier if > > we can just move features into virtio dev. > > If the comments in that thread are correct, it suggests that > *all* s390 virtio devices need to not have event_idx set, ie > this is not particularly special to virtio-blk. In that case > could we move the common properties to the base class where > they belong, but have the s390 virtio base class override > the properties to always suppress event-idx ? > > -- PMM That would be a reasonable work-around, yes. I still hope we can resolve it properly though. -- MST