From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnDOK-0000O4-J2 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 17:50:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnDOH-0002hG-DK for qemu-devel@nongnu.org; Tue, 28 Apr 2015 17:50:08 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:11223 helo=imgpgp01.kl.imgtec.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnDOG-0002ec-Ru for qemu-devel@nongnu.org; Tue, 28 Apr 2015 17:50:05 -0400 Date: Tue, 28 Apr 2015 22:50:03 +0100 From: James Hogan Message-ID: <20150428215003.GD22974@jhogan-linux.le.imgtec.org> References: <1430224874-18513-1-git-send-email-leon.alrae@imgtec.com> <1430224874-18513-7-git-send-email-leon.alrae@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5p8PegU4iirBW1oA" Content-Disposition: inline In-Reply-To: <1430224874-18513-7-git-send-email-leon.alrae@imgtec.com> Subject: Re: [Qemu-devel] [PATCH 6/7] target-mips: remove invalid comments in translate_init.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae Cc: qemu-devel@nongnu.org, aurelien@aurel32.net --5p8PegU4iirBW1oA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 28, 2015 at 01:41:13PM +0100, Leon Alrae wrote: > Signed-off-by: Leon Alrae I think this deserves a bit more explanation. Isn't 59 bits still the true architectural limit? Cheers James > --- > target-mips/translate_init.c | 9 --------- > 1 file changed, 9 deletions(-) >=20 > diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c > index 8e088c9..af6fb7a 100644 > --- a/target-mips/translate_init.c > +++ b/target-mips/translate_init.c > @@ -553,9 +553,6 @@ static const mips_def_t mips_defs[] =3D > (1 << FCR0_L) | (1 << FCR0_W) | (1 << FCR0_D) | > (1 << FCR0_S) | (0x00 << FCR0_PRID) | (0x0 << FCR0_R= EV), > .SEGBITS =3D 42, > - /* The architectural limit is 59, but we have hardcoded 36 bit > - in some places... > - .PABITS =3D 59, */ /* the architectural limit */ > .PABITS =3D 36, > .insn_flags =3D CPU_MIPS64R2 | ASE_MIPS3D, > .mmu_type =3D MMU_TYPE_R4000, > @@ -636,9 +633,6 @@ static const mips_def_t mips_defs[] =3D > (1 << FCR0_W) | (1 << FCR0_D) | (1 << FCR0_S) | > (0x00 << FCR0_PRID) | (0x0 << FCR0_REV), > .SEGBITS =3D 42, > - /* The architectural limit is 59, but we have hardcoded 36 bit > - in some places... > - .PABITS =3D 59, */ /* the architectural limit */ > .PABITS =3D 36, > .insn_flags =3D CPU_MIPS64R6, > .mmu_type =3D MMU_TYPE_R4000, > @@ -702,9 +696,6 @@ static const mips_def_t mips_defs[] =3D > (1 << FCR0_L) | (1 << FCR0_W) | (1 << FCR0_D) | > (1 << FCR0_S) | (0x00 << FCR0_PRID) | (0x0 << FCR0_R= EV), > .SEGBITS =3D 42, > - /* The architectural limit is 59, but we have hardcoded 36 bit > - in some places... > - .PABITS =3D 59, */ /* the architectural limit */ > .PABITS =3D 36, > .insn_flags =3D CPU_MIPS64R2 | ASE_DSP | ASE_DSPR2, > .mmu_type =3D MMU_TYPE_R4000, >=20 --5p8PegU4iirBW1oA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVQACLAAoJEGwLaZPeOHZ6IToP/23n1rPo82HWAU8w046i4MO/ 7KKfEvU/jyntFdLaGHpmJtWaXxWVoS4v/CqXfUEN8+7ZFhFNzKcrmUCoDTNpDwWU NpilEYVkYmUUWdEan0yz6U0/iPrEHpwvf4cZhBGNOUspES43kRHA+VW90SFWJs4W /LRxHIbTm/4ngJ+Jnucz5lDH5dHiRYr3oRYv69Bk5mcfkvzaeD77FhxMJGhBCQLN SjzL7PT9PnfMM8Qbt/K2fvqrvsh0A76GUGoZVFM/q3HrbGJhmohj2x8D1Sn2EUcC TbdHSQLnKCujQ0WU6Z42L1E0c5DUYKd6IaDIY2KQyKdUzuILAiuCPflxIF11dCHC z4zAeJdy70Uzbd3NIIDwkf8GMhl329JVSSiM5QkORXscl2uh/DNYxxTqI3rR6wH9 plgZVMMgJCMIk88DluTywXdJsfEwArhKVquHwjzA5038gJsN+Dpw2B3Zy/HNDMV6 WPfGyR/botJNmPYaAH9GRsPVWjGJkCK/18gyVm00cY7y0TjDeJknbfMqGudvAmVY R5FOYQz1U07eMa7cmZqs7vsl8JDCWMC0LiWp9UsM8hKoQq27QFQX2/4nL+jiI7q8 o49Yas4McclI78U5GM2vEgyZvC6/4vL+jlEyow2qvLggM5Lh1ZPj6Pn97D4M4Ohd ZkDQ6oGg8DTs5QHGYbae =a0b+ -----END PGP SIGNATURE----- --5p8PegU4iirBW1oA--