From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnHFn-000811-Hx for qemu-devel@nongnu.org; Tue, 28 Apr 2015 21:57:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnHFk-0006Hy-Us for qemu-devel@nongnu.org; Tue, 28 Apr 2015 21:57:35 -0400 Date: Wed, 29 Apr 2015 11:47:35 +1000 From: David Gibson Message-ID: <20150429014735.GA32589@voom.redhat.com> References: <76160645-F63F-4D9E-A228-ECDB92C56CC3@suse.de> <1428485601-26482-1-git-send-email-aik@ozlabs.ru> <20150410021622.GB27440@voom.redhat.com> <553F35F1.4010209@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline In-Reply-To: <553F35F1.4010209@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH qemu v2] qemu-options: Add documentation about PPC64's "-cpu compat" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 28, 2015 at 05:25:37PM +1000, Alexey Kardashevskiy wrote: > On 04/10/2015 12:16 PM, David Gibson wrote: > >On Wed, Apr 08, 2015 at 07:33:21PM +1000, Alexey Kardashevskiy wrote: > >>Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part = of > >>client-architecture-support patchset) there is a "compat" option > >>of "-cpu". However it was not documented at all and this is what this > >>patch is trying to do. > >> > >>Signed-off-by: Alexey Kardashevskiy > > > >I've updated the previous version in spapr-next. >=20 > That was bad idea. >=20 > First of all this patch is missing this: >=20 > diff --git a/vl.c b/vl.c > index 694deb4..12ffa1c 100644 > --- a/vl.c > +++ b/vl.c > @@ -2876,6 +2876,7 @@ int main(int argc, char **argv, char **envp) > break; > } > case QEMU_OPTION_cpu: > + case QEMU_OPTION_cpu_ppc: > /* hw initialization will check this */ > cpu_model =3D optarg; > break; >=20 >=20 > But even with it, "-cpu help" does not work as the "if (!(popt->arch_mask= & > arch_type))" fails at vl.c:2868 because QEMU_OPTION_cpu does not have > PPC64bit set (in order to hide unwanted options on x86) and > QEMU_OPTION_cpu_ppc is not "-cpu". >=20 > We should use the original patch or none at all. Ok, I've dropped this from spapr-next for the time being. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVQDg3AAoJEGw4ysog2bOS3oYP/3agzqqycG24GMvwzsenp8Fg Y1gARfra92Go1VImV8E8Tx0xCA4LCfZr8Nsfjh/+b/e4oQSiRrx05IlDNfkezUlA D0oz22g/1GPE/7D5bqrFSSgeHT+fC7TMMCRr5dT0N6aXkivce9Ug6i3Y11XX2GME qlyivzFz9vFRQf8ezDgjvE749K7/dpEaG9MiBVGKkT5R/LEuIrbYIpZ00boMtWJC sY5JPM1DVF72b6AuwUfnhKU/Y8gy62fHEs3OoGkUkEYwqj2fQGLyn46G8Qvow+UK 5zEPeiPHC4qfVmPmpLqnxAjU7vzLY7bkb8opYNrv9Qt7Db1yax/rxJorFNlKtKrl uqKDVe9WKIG54Bv9PnNVLcYYsCCI3J0j13/NiIA+hdsLqEhhc+jC4+Xi07heDzgP LLa6+R05HqJ+RW70qMR/xaxvaByniAZKiD/T5YZs0tfAHsJjvcXlEBKnwILb2WzH PJz3WHhq/wa5aVWfBdak3eLz7IWCWc2sljvdGKXJIjTobKWSoNGk4VeA4R0xXB8V OkWh3RdhsTFBLhMUzmKC3Cp5Q+sVXZz284tTeolTbPDtMBdFkIyY6eSP3rILV5nb ZBIBOTH22kMrGsCluTLqaObtK+au5Dfl6FqOj7PUqEkSoThoLhO9zkLEBvQF6iRg 03D5o73jjPK04uGlOJ7k =qu1F -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--