From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnNpz-0004BY-CF for qemu-devel@nongnu.org; Wed, 29 Apr 2015 04:59:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnNpx-0000xr-TK for qemu-devel@nongnu.org; Wed, 29 Apr 2015 04:59:23 -0400 Date: Wed, 29 Apr 2015 10:27:26 +0200 From: Kevin Wolf Message-ID: <20150429082726.GA3644@noname.str.redhat.com> References: <1430233258-31807-1-git-send-email-kwolf@redhat.com> <1430233258-31807-77-git-send-email-kwolf@redhat.com> <553FC01B.5030802@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm" Content-Disposition: inline In-Reply-To: <553FC01B.5030802@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PULL 76/76] block: move I/O request processing to block/io.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 28.04.2015 um 19:15 hat Eric Blake geschrieben: > On 04/28/2015 09:00 AM, Kevin Wolf wrote: > > From: Stefan Hajnoczi > >=20 > > The block.c file has grown to over 6000 lines. It is time to split this > > file so there are fewer conflicts and the code is easier to maintain. > >=20 > > Extract I/O request processing code: > > * Read > > * Write > > * Zero writes and making the image empty > > * Flush > > * Discard > > * ioctl > > * Tracked requests and queuing > > * Throttling and copy-on-read > > * Block status and allocated functions > > * Refreshing block limits > > * Reading/writing vmstate > > * qemu_blockalign() and friends > >=20 > > The patch simply moves code from block.c into block/io.c. > >=20 > > Signed-off-by: Stefan Hajnoczi > > Signed-off-by: Kevin Wolf > > --- > > block.c | 3394 +++++++------------------------------------= -------- > > block/Makefile.objs | 2 +- > > block/io.c | 2540 ++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 2982 insertions(+), 2954 deletions(-) > > create mode 100644 block/io.c >=20 > Kevin, compare your diff to Stefan's: >=20 > > --- > > block.c | 2512 -------------------------------------------= ------- > > block/Makefile.objs | 2 +- > > block/io.c | 2540 +++++++++++++++++++++++++++++++++++++++++++= ++++++++ > > 3 files changed, 2541 insertions(+), 2513 deletions(-) > > create mode 100644 block/io.c >=20 > The difference is that Stefan has done 'git config diff.algorithm > patience', which makes for MUCH more legible diffs on a code motion > patch. http://wiki.qemu.org/Contribute/SubmitAPatch mentions this as a > hint for a nicer setup. Indeed, it does. I used --patience for reviewing the patch but neglected to add it when sending the pull request. That said, I don't think I could have enabled it for a single patch, and I'm not sure if it's universally better (if so, why wouldn't it be the default?) > At any rate, you've already sent the pull request, so I'm probably too > late; but for the record, here's why I would add: > Reviewed-by: Eric Blake > when reviewing Stefan's version of the patch (the two versions give the > same end result, but my review technique falls flat on Kevin's replay of > the patch) You could apply both series and diff the result if you wanted. But this one was easy enough to review on my own (...famous last words?) Kevin --EVF5PPMfhYS0aIcm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJVQJXtAAoJEH8JsnLIjy/WQxEQALaDTHuaCIWX+r5zhTkCb9s4 k5iExav6vZ5DGyhPVQ2fyMM6oB9EDXI2hiOy98ex5m2yl+xgbCudCv3X3jd/MxC0 5YSrbEw7cnRH7a1mBzllWIJUCVMCWZQUXgg7sJcLqLhFV+ONk4+aynyY3m2dLdj4 ukoWfFpY8Lf+T5kVlIGGWPfnQ2Dc2pzdp6qy0ktzm6osm0B+e1q1SvS9izT6rCMi Vo2L62Jm423zJuz7rlVIT1wecUMFMXGDIYuG8iNMmKGKL/P1Px9gnqzjzuqVFcYN JheGjHHdhX/U6SSXxODQ/62CKNubndTIxq2bEqieZfkrIQNd9hO8JQx/FEpgWOaw xO3OfEMVGGs570+JBycvjQO8zbiCwqGj/qyDFw5kJr5eDFmqap4pTpYX0fB1jOmC Sb5zy4O8KAxRHq9FGplOgmLYkDEVIVA/48Qe0yn6HISsPnj8dghQPpyOSMKravWe zJa0/XN45SL8QidDEg94wziBfvIwyjNJLXJtNp8KXhegZZZGKGKBJ/9AVkEKU8tm ElC3oi8bIQ5iIvYO7LItq/yLiEHtM8fb4KvAPo+CJbudJCXr5rlpVEu3nl3Mfj20 bDS/I84vP8ouTJi2tUfoIDNCcd54yMBh+WLLXQh5BuHJC9yl4TFV6RHjDnT9uEf7 2DM4wbtxU3eycfBwAMVm =Ncs/ -----END PGP SIGNATURE----- --EVF5PPMfhYS0aIcm--