From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53760)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1YnRVP-00083H-3o
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 08:54:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1YnRVK-0004AY-5l
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 08:54:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60373)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1YnRVJ-0004AO-Sr
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 08:54:18 -0400
Date: Wed, 29 Apr 2015 08:54:11 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20150429085411.182e4578@redhat.com>
In-Reply-To: <5540D2AE.2090802@suse.de>
References: <1429975686-19494-1-git-send-email-ehabkost@redhat.com>
	<553BC973.2030506@suse.de>
	<20150427172320.GC25766@thinpad.lan.raisama.net>
	<20150429083802.06f102ea@redhat.com> <5540D2AE.2090802@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, agraf@suse.de, Juan Quintela <quintela@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org

On Wed, 29 Apr 2015 14:46:38 +0200
Andreas F=C3=A4rber <afaerber@suse.de> wrote:

> Am 29.04.2015 um 14:38 schrieb Luiz Capitulino:
> > On Mon, 27 Apr 2015 14:23:20 -0300
> > Eduardo Habkost <ehabkost@redhat.com> wrote:
> >=20
> >> On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas F=C3=A4rber wrote:
> >>> Am 25.04.2015 um 17:28 schrieb Eduardo Habkost:
> >>>> The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CH=
ECK.
> >>>> There were even some functions using object_dynamic_cast() calls
> >>>> followed by assert(), which is exactly what OBJECT_CHECK does (by
> >>>> calling object_dynamic_cast_assert()).
> >>>
> >>> Suggest s/OBJECT_CHECK/OBJECT_CHECK()/g everywhere for clarity.
> >=20
> > Everywhere? You mean, in other places?
>=20
> No, I count 3x in commit message including subject.

Ah, the problem is the *commit* message. Okay...

>=20
> Andreas
>=20
> > In this case someone has to
> > post a different patch.
> >=20
> >> I assume it can be fixed during commit by whoever is going to queue it.
> >>
> >>>
> >>>>
> >>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> >>>> ---
> >>>>  qjson.c | 10 +++++-----
> >>>>  1 file changed, 5 insertions(+), 5 deletions(-)
> >>>
> >>> Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>
> >>>
> >>> Wasn't aware QJSON is using QOM - assuming this will go through some
> >>> QAPI/QMP tree.
> >>
> >> The only user of qjson.c right now is migration code. Should it go thr=
ough
> >> the migration tree?
> >=20
> > It could be, but I can take it if nobody does.
> >=20
> >> Also, why do we have two JSON writers in QEMU? And why do they have
> >> exactly the same name?
> >=20
> > Not sure I got it, which writers?
> >=20
>=20
>=20