From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
hangaohuai@huawei.com, QEMU Developers <qemu-devel@nongnu.org>,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Shannon Zhao <shannon.zhao@linaro.org>,
Shannon Zhao <zhaoshenglong@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends
Date: Wed, 29 Apr 2015 20:32:50 +0200 [thread overview]
Message-ID: <20150429203237-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20150429163344.5ecfcea8.cornelia.huck@de.ibm.com>
On Wed, Apr 29, 2015 at 04:33:44PM +0200, Cornelia Huck wrote:
> On Wed, 29 Apr 2015 12:32:04 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote:
>
> > > And (surprise, surprise) virtio-blk now works - but it also works when
> > > I back out the atomic.h change again. No barrier problems :)
> > >
> > > Good news is that we can change s390-virtio to be just like the other
> > > transports. Although I'd like to understand why it was broken before.
> > > Maybe a guest change?
> >
> > Or a compiler change? Try compiling some old release, see what happens.
>
> Nope, same compiler as back then (old setup). My current guess is some
> change in other code.
bisect is you friend then :)
> > Anyway, let's move DEFINE_VIRTIO_COMMON_FEATURES into the base class
> > now. Can you send a patch pls?
>
> I think virtio-blk-s390 not working anymore will be easy to catch (it
> is used in some of the iotests). I'll move the features.
next prev parent reply other threads:[~2015-04-29 18:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 11:51 [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends shannon.zhao
2015-04-28 11:51 ` [Qemu-devel] [PATCH v4 1/2] virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net shannon.zhao
2015-04-28 11:51 ` [Qemu-devel] [PATCH v4 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi shannon.zhao
2015-04-28 12:48 ` [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends Michael S. Tsirkin
2015-04-28 12:52 ` Peter Maydell
2015-04-28 13:05 ` Michael S. Tsirkin
2015-04-28 13:20 ` Cornelia Huck
2015-04-28 14:03 ` Michael S. Tsirkin
2015-04-28 13:06 ` Peter Maydell
2015-04-28 13:13 ` Michael S. Tsirkin
2015-04-28 13:16 ` Peter Maydell
2015-04-28 13:24 ` Cornelia Huck
2015-04-28 14:35 ` Michael S. Tsirkin
2015-04-28 18:14 ` Michael S. Tsirkin
2015-04-28 18:32 ` Michael S. Tsirkin
2015-04-28 18:35 ` Michael S. Tsirkin
2015-04-29 8:17 ` Christian Borntraeger
2015-04-29 8:52 ` Cornelia Huck
2015-04-29 10:32 ` Michael S. Tsirkin
2015-04-29 14:33 ` Cornelia Huck
2015-04-29 18:32 ` Michael S. Tsirkin [this message]
2015-04-29 14:43 ` Christian Borntraeger
2015-04-29 18:35 ` Michael S. Tsirkin
2015-04-29 19:49 ` Christian Borntraeger
2015-04-29 20:19 ` Michael S. Tsirkin
2015-04-30 15:50 ` Christian Borntraeger
2015-04-28 18:34 ` Peter Maydell
2015-04-28 18:38 ` Michael S. Tsirkin
2015-04-29 9:55 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429203237-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=christoffer.dall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=hangaohuai@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).