From: Kevin Wolf <kwolf@redhat.com>
To: Keith Busch <keith.busch@intel.com>
Cc: Daniel Stekloff <dan@wendan.org>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Enable NVMe start controller for Windows guest.
Date: Thu, 30 Apr 2015 15:36:21 +0200 [thread overview]
Message-ID: <20150430133621.GC25594@noname.redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1504241907590.19844@localhost.lm.intel.com>
[Cc: qemu-block]
Am 24.04.2015 um 21:19 hat Keith Busch geschrieben:
> On Fri, 24 Apr 2015, Daniel Stekloff wrote:
> >Windows seems to send two separate calls to NVMe controller configuration. The
> >first sends configuration info and the second the enable bit. I couldn't
> >enable the Windows 8.1 in-box NVMe driver with base Qemu. I made the
> >following change to store the configuration data and then handle enable and
> >NVMe driver works on Windows 8.1.
>
> Hm, Microsoft's driver must be issuing MMIO reads to mask in the enable
> bit rather than keep the state known. Sounds odd, but thanks for the fix.
>
> Acked-by: Keith Busch <keith.busch@intel.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2015-04-30 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 18:55 [Qemu-devel] [PATCH] Enable NVMe start controller for Windows guest Daniel Stekloff
2015-04-24 19:19 ` Keith Busch
2015-04-30 13:36 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430133621.GC25594@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=dan@wendan.org \
--cc=keith.busch@intel.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).