From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ynus3-0003VZ-II for qemu-devel@nongnu.org; Thu, 30 Apr 2015 16:15:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ynury-0005VQ-Ft for qemu-devel@nongnu.org; Thu, 30 Apr 2015 16:15:43 -0400 Date: Thu, 30 Apr 2015 22:15:34 +0200 From: Kevin Wolf Message-ID: <20150430201534.GB3545@noname.redhat.com> References: <1430418196-8691-1-git-send-email-dslutz@verizon.com> <55427F5A.5090608@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <55427F5A.5090608@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Paolo Bonzini , qemu block , qemu-devel@nongnu.org, Don Slutz --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 30.04.2015 um 21:15 hat Eric Blake geschrieben: > [adding qemu-block] >=20 > On 04/30/2015 12:23 PM, Don Slutz wrote: > > ~/qemu/out/master/x86_64-softmmu/qemu-system-x86_64 -h | head > > QEMU emulator version 2.3.50, Copyright (c) 2003-2008 Fabrice Bellard > > usage: qemu-system-x86_64 [options] [disk_image] > >=20 > > 'disk_image' is a raw hard disk image for IDE hard disk 0 > >=20 > > Standard options: > > ... > >=20 > > Signed-off-by: Don Slutz > > --- > > vl.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > Reviewed-by: Eric Blake >=20 > Without this, qemu will try to probe formats. It is arguably is more > convenient when using the shorthand of supplying a disk image to let > qemu pick the format; but as the --help text says the image is raw, it's > better to be explicit and avoid probing. Besides, we can always use > longhand to specify actual format and/or probing if we don't like the > shorthand. I don't think you can take an outdated help text as a justification for breaking backwards compatibility. Kevin > >=20 > > diff --git a/vl.c b/vl.c > > index 74c2681..93e674f 100644 > > --- a/vl.c > > +++ b/vl.c > > @@ -1084,6 +1084,7 @@ static int cleanup_add_fd(QemuOpts *opts, void *o= paque) > > /* QEMU Block devices */ > > =20 > > #define HD_OPTS "media=3Ddisk" > > +#define HD_OPTS_RAW "media=3Ddisk,format=3Draw" > > #define CDROM_OPTS "media=3Dcdrom" > > #define FD_OPTS "" > > #define PFLASH_OPTS "" > > @@ -2862,7 +2863,7 @@ int main(int argc, char **argv, char **envp) > > if (optind >=3D argc) > > break; > > if (argv[optind][0] !=3D '-') { > > - hda_opts =3D drive_add(IF_DEFAULT, 0, argv[optind++], HD_O= PTS); > > + hda_opts =3D drive_add(IF_DEFAULT, 0, argv[optind++], HD_O= PTS_RAW); > > } else { > > const QEMUOption *popt; > > =20 > >=20 >=20 > --=20 > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >=20 --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJVQo1mAAoJEH8JsnLIjy/Wnr0QAKdMfgvQgTZzIZkDqO4rpboS /AHYo5z1GaSMujCz0fsSxAezaxjbawWXcOtp7UDN4wjwDGf3V4pldhmVEMmnkAgv q8CBRtTmkVn5LQwYW5zdPem/sKd9yotWKSKNAkiw72O1fCxYsPPrlbp+kroioSUg yhw0pTFDNrEWnjVTEFDAg6lb1+eqmdGjhPiKzdVzmefAXIc8BJCSD1jyFx0t6UoI 3BQO73TSojaYXs0g0EeKxaYoDiERSHufwst3Zh/6pcrc/MqqqXaEhUjCVF4N52vG QQEC6B2cuOJEd+6jOZ78E7Ivx7FxUNRpZppmUzfIh2mVtGPUo+c4E0bY8lk3onDe aYCSeA+RP6py4eBABkbca/zEfLHAMrK4vY6lXQqCJPH9hQiUZWoNJk4e8wMb/C4H O1qfvvKz8RHxUjesmd8Ez21fbuNFvIM45XPR6zLxr2+wWsNZsfbi3X+Dron8Y6Dx Fwjc6S7k+gkZGasQZaTwpqZAi+XOeAShlPsw00n7bJCBXaLxr33grtU+rrtdIGfE k3j1NjXuMEhJXZbjev0xPZN9AUm1VGxbeuNBjFg8mNTXS6/TwiS+QNzHBySWPl6w RGPS4vtahmL9GnNlh7pQRkVfQWogszrfrcUagxkSkeGhuN3YGNUBeI/NabSmVdrk 6LJ8TcBCJPZBX6BotJ0j =SgHO -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--