From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55017)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1YnziB-0001DB-VP
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 21:25:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Ynzi8-0005yb-OK
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 21:25:51 -0400
Received: from e19.ny.us.ibm.com ([129.33.205.209]:40889)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Ynzi8-0005yT-JQ
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 21:25:48 -0400
Received: from /spool/local
	by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;
	Thu, 30 Apr 2015 21:25:47 -0400
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <5542374A.7070404@redhat.com>
References: <1430335224-6716-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1430335224-6716-9-git-send-email-mdroth@linux.vnet.ibm.com>
	<5542374A.7070404@redhat.com>
Message-ID: <20150501012542.25451.63694@loki>
Date: Thu, 30 Apr 2015 20:25:42 -0500
Subject: Re: [Qemu-devel] [RFC PATCH 08/15] spapr: create DR connectors for
 PHBs and register reset hooks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: aik@ozlabs.ru, nfont@linux.vnet.ibm.com, david@gibson.dropbear.id.au, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com

Quoting Paolo Bonzini (2015-04-30 09:08:10)
> =

> =

> On 29/04/2015 21:20, Michael Roth wrote:
> > +    if (spapr->dr_phb_enabled) {
> > +        for (i =3D 0; i < SPAPR_DRC_MAX_PHB; i++) {
> > +            sPAPRDRConnector *drc =3D
> > +                spapr_dr_connector_new(OBJECT(machine),
> > +                                       SPAPR_DR_CONNECTOR_TYPE_PHB, i);
> > +            qemu_register_reset(spapr_drc_reset, drc);
> > +        }
> > +    }
> =

> Is this needed because drc is busless?  Then I think it should be done
> in device_set_realized (and the matching qemu_unregister_reset too).

You mean move the qemu_register_reset() to DRC->realize()? Don't recall
if there was a reason I did it this way, but that does seem a lot
cleaner.

And yah, no bus for DRCs, so we're not hooked into qbus_reset_all_fn()

> =

> Paolo
>=20